From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933161AbcH2MVZ (ORCPT ); Mon, 29 Aug 2016 08:21:25 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:56737 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932211AbcH2MVX (ORCPT ); Mon, 29 Aug 2016 08:21:23 -0400 From: Arnd Bergmann To: Baoyou Xie Subject: Re: [PATCH] mISDN: mark symbols static where possible Date: Mon, 29 Aug 2016 14:15:41 +0200 User-Agent: KMail/1.12.2 (Linux/4.7.0-rc7+; KDE/4.3.2; x86_64; ; ) Cc: isdn@linux-pingi.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn References: <1472471973-23041-1-git-send-email-baoyou.xie@linaro.org> In-Reply-To: <1472471973-23041-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201608291415.41294.arnd@arndb.de> X-Provags-ID: V03:K0:VwI6zq3bu/3mLSrS/V3m3gdSAYC2PVQmpGaLKljkEO9jC78lOuk c6bef8VmVvwcaZzjm9jnq+LgDGSNoWWn0qEgYfTvRPQ2vmmwEZ0lgo2PwBjsOs2LNY72mm9 pQvhKT/G1ceYJ64aWgMGwDmvNXlW/J9P/XAVsLnrarkYU9aVb0S0JPIAsvP5i5eRtqWat2d gAMN+4a3mmTj2q5a5YJ4w== X-UI-Out-Filterresults: notjunk:1;V01:K0:ECToOSnJRnk=:RkensR+QK0UdhderNrKYLE orRHnJLSf+0HXKdBvMT5GXNRxkgSALnRkiNYws1qF0zmD9PVnVRJ7grA50K7YcJNnjUxJ43P7 fkOOPiI3ZtRr/13tpBkYwwoIxDwlamIDkCB558htnl7H90qpRpHZvZRGAM2VDkFBTd/vP/dCf V8vPH5gifgddc/pNo8xc9p01UnGQIcydSSnsMpPa8JGBVZDdcYLnEikY+VI/qS9JehfF+73zS X/HMruqc8eJvEutnqYD2IhejdJMBulcrytrrqwFhQyzMmJuDf4m0FYr+Xn0L03Lqi0Vd3agRL b1O/ic0ziyXuboEw/yqQ+R/Rvsri3PvtgqGTMCTZobWk9sMScOOjtSOGFotqEJ92gGWMj/otS +Sle1TLCZv72EIxbhcbTNny9bqXcwDOUxRblbdgVmlXN/qGcX+2aJV4m4oQYfvS1CZNV7ULC3 4mizlJUsKO50FYMwYieOOO/63U/JwqU3IVai5TQNCLpyhCvWDhV+J11iEskAG0zc8l4wFXnF1 rHrFsmg7y9TiAsmnhi5tj9/R3E/LLZqhCTTLwphH6Br4orTkEWjAnnT5MCSnoFvu1vwqvv/z6 e1oGI16BOH/GdjV/g3e+eF4CYxrrUFFYFXC75x7PzGG2Ersc22LJyBx1ICxQivXWg0fzIkpEN dV3W3K8tZmdxGxOlNtN12gkcWwwYLh1J+Opi0cew4FhB0Grnm7OQFKCxUkmxd19FJc5YN9wLN 0FzsyijdfFCjfPz4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 29 August 2016, Baoyou Xie wrote: > We get 1 warning when biuld kernel with W=1: > drivers/isdn/hardware/mISDN/w6692.c:851:6: warning: no previous prototype for 'initW6692' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared > and don't need a declaration, but can be made static. > so this patch marks it 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/isdn/hardware/mISDN/w6692.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The patch looks good, but now you have sent two different patches with the same subject line. Since this is just one driver and each instance is a trivial change, I'd suggest doing a single combined patch for them. Similarly, when you have multiple patches within one subsystem (e.g. two different scsi drivers), it helps to have a series of patches as you did with the ASoC patches. Arnd