From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756596AbcH2W72 (ORCPT ); Mon, 29 Aug 2016 18:59:28 -0400 Received: from smtprelay0069.hostedemail.com ([216.40.44.69]:53150 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754167AbcH2W71 (ORCPT ); Mon, 29 Aug 2016 18:59:27 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3353:3622:3865:3867:3870:3871:3872:4321:5007:6120:6261:7875:10004:10400:10848:10967:11026:11232:11658:11914:12555:12740:13069:13311:13357:13439:14181:14659:14721:21080:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: apple14_515f0703bd25a X-Filterd-Recvd-Size: 2577 Date: Mon, 29 Aug 2016 18:59:17 -0400 From: Steven Rostedt To: Dmitry Safonov Cc: , , , , , , <0x7f454c46@gmail.com>, , Subject: Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe Message-ID: <20160829185917.170e8aad@gandalf.local.home> In-Reply-To: <20160829185813.6d044a8e@gandalf.local.home> References: <20160825152110.25663-1-dsafonov@virtuozzo.com> <20160825152110.25663-3-dsafonov@virtuozzo.com> <20160829185813.6d044a8e@gandalf.local.home> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Aug 2016 18:58:13 -0400 Steven Rostedt wrote: > On Thu, 25 Aug 2016 18:21:09 +0300 > Dmitry Safonov wrote: > > > It's useless. Before: > > [tracing]# echo 'p:test /a:0x0' >> uprobe_events > > [tracing]# echo 'p:test a:0x0' >> uprobe_events > > -bash: echo: write error: No such file or directory > > [tracing]# echo 'p:test 1:0x0' >> uprobe_events > > -bash: echo: write error: Invalid argument > > > > After: > > [tracing]# echo 'p:test 1:0x0' >> uprobe_events > > -bash: echo: write error: No such file or directory > > > > Signed-off-by: Dmitry Safonov > > Acked-by: Steven Rostedt Actually, this patch seems agnostic to the series. I'll just pull it in now. -- Steve > > > --- > > kernel/trace/trace_uprobe.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > > index c53485441c88..a74f2d9ff379 100644 > > --- a/kernel/trace/trace_uprobe.c > > +++ b/kernel/trace/trace_uprobe.c > > @@ -427,10 +427,6 @@ static int create_trace_uprobe(int argc, char **argv) > > pr_info("Probe point is not specified.\n"); > > return -EINVAL; > > } > > - if (isdigit(argv[1][0])) { > > - pr_info("probe point must be have a filename.\n"); > > - return -EINVAL; > > - } > > arg = strchr(argv[1], ':'); > > if (!arg) { > > ret = -EINVAL; >