From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756737AbcHaGcv (ORCPT ); Wed, 31 Aug 2016 02:32:51 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:38396 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751264AbcHaGct (ORCPT ); Wed, 31 Aug 2016 02:32:49 -0400 Date: Tue, 30 Aug 2016 23:32:38 -0700 (PDT) Message-Id: <20160830.233238.1711742937489908366.davem@davemloft.net> To: arnd@arndb.de Cc: sergei.shtylyov@cogentembedded.com, ykaneko0929@gmail.com, kazuya.mizuguchi.ks@renesas.com, horms+renesas@verge.net.au, masaru.nagai.vx@renesas.com, niklas.soderlund+renesas@ragnatech.se, netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ravb: avoid unused function warnings From: David Miller In-Reply-To: <20160826153108.680850-1-arnd@arndb.de> References: <20160826153108.680850-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 30 Aug 2016 23:32:41 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Fri, 26 Aug 2016 17:30:29 +0200 > When CONFIG_PM_SLEEP is disabled, we get a couple of harmless warnings: > > drivers/net/ethernet/renesas/ravb_main.c:2117:12: error: 'ravb_resume' defined but not used [-Werror=unused-function] > drivers/net/ethernet/renesas/ravb_main.c:2104:12: error: 'ravb_suspend' defined but not used [-Werror=unused-function] > > The simplest solution here is to replace the #ifdef with __maybe_unused > annotations, which lets the compiler do the right thing by itself. > > Signed-off-by: Arnd Bergmann > Fixes: 0184165b2f42 ("ravb: add sleep PM suspend/resume support") Applied, thanks.