From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752448AbcH3Nwq (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 Aug 2016 09:52:46 -0400
Received: from smtprelay0134.hostedemail.com ([216.40.44.134]:38629 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751563AbcH3Nwm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 Aug 2016 09:52:42 -0400
X-Session-Marker: 726F737465647440676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:3873:4362:5007:6261:7875:7974:9040:10004:10400:10848:10967:11026:11232:11658:11914:12043:12296:12438:12663:12740:13069:13138:13231:13311:13357:13439:14096:14097:14180:14181:14659:14721:14819:21060:21080:21324:30012:30054:30060:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none
X-HE-Tag: straw48_173f3610df52b
X-Filterd-Recvd-Size: 2312
Date: Tue, 30 Aug 2016 09:52:38 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Binoy Jayan <binoy.jayan@linaro.org>
Cc: Daniel Wagner <daniel.wagner@bmw-carit.de>,
        Ingo Molnar <mingo@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
        linaro-kernel@lists.linaro.org, Carsten Emde <C.Emde@osadl.org>,
        Linux kernel mailing list <linux-kernel@vger.kernel.org>,
        Masami <masami.hiramatsu@linaro.org>
Subject: Re: [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints
Message-ID: <20160830095238.57d4e781@gandalf.local.home>
In-Reply-To: <CAHv-k_9zS5yEF2cxf3gVEEX7C9qjdWUbZBebC=UFmPM6OUo8dA@mail.gmail.com>
References: <1472453728-577-1-git-send-email-binoy.jayan@linaro.org>
        <1472453728-577-3-git-send-email-binoy.jayan@linaro.org>
        <fe9ddd6d-e36b-e43b-9d2c-9d09f2aed9de@bmw-carit.de>
        <CAHv-k_9zS5yEF2cxf3gVEEX7C9qjdWUbZBebC=UFmPM6OUo8dA@mail.gmail.com>
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 30 Aug 2016 15:11:26 +0530
Binoy Jayan <binoy.jayan@linaro.org> wrote:

> On 29 August 2016 at 15:13, Daniel Wagner <daniel.wagner@bmw-carit.de> wrote:
> > Hi Binoy,
> >
> > Some minor nitpicking.
> >
> > As Steven already pointed out, the cpu field is available in all traces.
> > It's one of the predefined fields (see
> > kernel/trace/trace_events.c/trace_define_generic_fields()). Just drop it.
> >  
> 
> Hi Daniel,
> 
> Thank you for looking at the patch again. When I do not use cpu as a field,
> I am not able to make it part of the key or value fields. I can only
> use cpu in the
> filter predicate.
> 
> For example, the following trigger does not seem to work:
> 'hist:key=ltype,cpu:val=latency:sort=ltype,cpu if ltype==0'
> 
> But the following works:
> 'hist:key=ltype,latency:val=hitcount:sort=latency if cpu==1'

What about using "CPU" (all caps)? Look at
kernel/trace/trace_events_filter.c for FILTER_CPU.

Lets not add fields when we can fix the generic code to process these.

Thanks!

-- Steve