From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757512AbcH3Pmi (ORCPT ); Tue, 30 Aug 2016 11:42:38 -0400 Received: from smtprelay0048.hostedemail.com ([216.40.44.48]:41999 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757473AbcH3Pme (ORCPT ); Tue, 30 Aug 2016 11:42:34 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2892:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3871:3872:3873:4184:4250:4321:4362:5007:6119:6261:7875:7903:9040:10004:10400:10848:10967:11232:11658:11914:12295:12555:12740:13439:13870:13904:14180:14181:14659:14721:21060:21080:21324:30054:30075:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: cars14_6d7db7452f70d X-Filterd-Recvd-Size: 3150 Date: Tue, 30 Aug 2016 11:42:30 -0400 From: Steven Rostedt To: Baolin Wang Cc: Ingo Molnar , John Stultz , Thomas Gleixner , Mark Brown , LKML Subject: Re: [PATCH v3] time: alarmtimer: Add the trcepoints for alarmtimer Message-ID: <20160830114230.2f4bce51@gandalf.local.home> In-Reply-To: References: <27d8c8be532b025a1e68d710ff539b8923c9d4cb.1471839665.git.baolin.wang@linaro.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Aug 2016 19:50:20 +0800 Baolin Wang wrote: > Hi, > > On 22 August 2016 at 12:23, Baolin Wang wrote: > > For system debugging, we usually want to know who sets one alarm timer, the > > time of the timer, when the timer started and fired and so on. Thus adding > > tracepoints can help us trace the alarmtimer information. > > > > For example, when we debug the system supend/resume, if the system is always > > resumed by RTC alarm, we can find out which process set the alarm timer to > > resume system by below trace log: > > > > ...... > > Binder:2976_6-3473 [005] d..2 1076.587732: alarmtimer_start: process:Binder:2976_6 > > alarmtimer type:ALARM_BOOTTIME expires:1234154000000 time: 1970-1-1 0:20:35 > > > > Binder:2976_7-3480 [002] d..2 1076.592707: alarmtimer_cancel: process:Binder:2976_7 > > alarmtimer type:ALARM_BOOTTIME expires:1325463060000000000 time: 2012-1-2 0:11:0 > > > > Binder:2976_7-3480 [002] d..2 1076.592731: alarmtimer_start: process:Binder:2976_7 > > alarmtimer type:ALARM_BOOTTIME expires:1325378040000000000 time: 2012-1-1 0:34:0 > > > > system_server-2976 [003] d..2 1076.605587: alarmtimer_cancel: process:system_server > > alarmtimer type:ALARM_BOOTTIME expires:1234154000000 time: 1970-1-1 0:20:35 > > > > system_server-2976 [003] d..2 1076.605608: alarmtimer_start: process:system_server > > alarmtimer type:ALARM_BOOTTIME expires:1234155000000 time: 1970-1-1 0:20:35 > > > > system_server-3000 [002] ...1 1087.737565: alarmtimer_suspend: alarmtimer type:ALARM_BOOTTIME > > expires time: 2012-1-1 0:34:0 > > ...... > > > > From the trace log, we can find out the 'Binder:2976_7' process set one alarm > > timer which resumes the system. > > Do you have any comments about this patch? Thanks. Looks fine to me. Acked-by: Steven Rostedt Now you need to get the time maintainers to accept it. Thanks! -- Steve > > > > > Signed-off-by: Baolin Wang > > ---