From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752721AbcH3VGc (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 Aug 2016 17:06:32 -0400
Received: from smtprelay0119.hostedemail.com ([216.40.44.119]:39598 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1750859AbcH3VGb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 Aug 2016 17:06:31 -0400
X-Session-Marker: 726F737465647440676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:4250:5007:6261:7875:8603:10004:10400:10848:10967:11026:11232:11658:11914:12740:13069:13138:13231:13311:13357:13439:14181:14659:14721:21080:30054:30056:30060:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: sun75_1b5419a01aa06
X-Filterd-Recvd-Size: 2101
Date: Tue, 30 Aug 2016 17:06:26 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: Binoy Jayan <binoy.jayan@linaro.org>, Ingo Molnar <mingo@redhat.com>,
        Arnd Bergmann <arnd@arndb.de>, <linaro-kernel@lists.linaro.org>,
        Carsten Emde <C.Emde@osadl.org>,
        Linux kernel mailing list <linux-kernel@vger.kernel.org>,
        Masami <masami.hiramatsu@linaro.org>
Subject: Re: [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints
Message-ID: <20160830170626.653c9501@gandalf.local.home>
In-Reply-To: <e0ec2448-6460-7b84-084d-f59dbd9604e5@bmw-carit.de>
References: <1472453728-577-1-git-send-email-binoy.jayan@linaro.org>
        <1472453728-577-3-git-send-email-binoy.jayan@linaro.org>
        <fe9ddd6d-e36b-e43b-9d2c-9d09f2aed9de@bmw-carit.de>
        <CAHv-k_9zS5yEF2cxf3gVEEX7C9qjdWUbZBebC=UFmPM6OUo8dA@mail.gmail.com>
        <20160830095238.57d4e781@gandalf.local.home>
        <866e5451-6367-f0c5-b2c6-1ce5e5737fe1@bmw-carit.de>
        <498d04b6-a0ac-1442-9c65-154f5c4923be@bmw-carit.de>
        <e0ec2448-6460-7b84-084d-f59dbd9604e5@bmw-carit.de>
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 30 Aug 2016 17:02:03 +0200
Daniel Wagner <daniel.wagner@bmw-carit.de> wrote:

> On 08/30/2016 04:20 PM, Daniel Wagner wrote:
> > Just setting the size of the type is not enough. The hist_field_* 
> > getter function want to know the offset too:  
> 
> With this hack here it should work. The COMM generic field is handled via
> the tracing_map_ops. We could do it also there but than we need to 
> a condition in the trace_map_ops if it is COMM or CPU. 
> This shortcut here avoids it:
> 

I think the tracing_map_ops is the proper fix. I'd like to keep comm
and cpu identical, as they are both basically "meta fields".

-- Steve