From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759015AbcHaHff (ORCPT ); Wed, 31 Aug 2016 03:35:35 -0400 Received: from down.free-electrons.com ([37.187.137.238]:52321 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752780AbcHaHfa (ORCPT ); Wed, 31 Aug 2016 03:35:30 -0400 Date: Wed, 31 Aug 2016 09:34:29 +0200 From: Boris Brezillon To: Hyung Jin Jung Cc: "airlied@linux.ie" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: drm/atmel-hlcdc: connector type & fbdev mode settings Message-ID: <20160831093429.164e5ddc@bbrezillon> In-Reply-To: <61FA15C5AEE1ED4E827ADEB50820C1443EB181948F@MAIL03.corp.lgcns.com> References: <61FA15C5AEE1ED4E827ADEB50820C1443EB181948F@MAIL03.corp.lgcns.com> Organization: Free Electrons X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 31 Aug 2016 11:29:53 +0900 Hyung Jin Jung wrote: > According to Atmel's guideline... http://www.at91.com/linux4sam/bin/view/Linux4SAM/UsingAtmelDRMDriver > > the "fbdev emulation mode" could be set from kernel command line (LVDS-1:...) > however, driver register it as DRM_MODE_CONNECTOR_Unknown connector. Just adapt the command line with Unknown-1:... > > Actually we using sama5d3x with LVDS cable so that below patch would be correct. No it wouldn't. The sama5 SoC is providing a raw RGB interface, so if you really have an LVDS interface on your board this means you have a bridge in the middle. This bridge should be represented in the DT, and attached to a driver in the kernel. > But I don't know the other case such as HDMI, composite... > > Do we need to consider using DT or auto-detection?? > > Signed-off-by: HyungJin Jung > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c > index 6119b50..da97efe > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c > @@ -208,7 +208,7 @@ static int atmel_hlcdc_attach_endpoint(struct drm_device *dev, > &atmel_hlcdc_panel_connector_helper_funcs); > ret = drm_connector_init(dev, &output->connector, > &atmel_hlcdc_panel_connector_funcs, > - DRM_MODE_CONNECTOR_Unknown); > + DRM_MODE_CONNECTOR_LVDS); > if (ret) > goto err_encoder_cleanup; >