From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935029AbcHaOGe (ORCPT ); Wed, 31 Aug 2016 10:06:34 -0400 Received: from mail-yb0-f180.google.com ([209.85.213.180]:33564 "EHLO mail-yb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933593AbcHaOGd (ORCPT ); Wed, 31 Aug 2016 10:06:33 -0400 Date: Wed, 31 Aug 2016 10:06:30 -0400 From: Tejun Heo To: Bhaktipriya Shridhar Cc: Joshua Morris , Philip Kelleher , linux-kernel@vger.kernel.org Subject: Re: [PATCH] rsxx: Remove deprecated create_singlethread_workqueue Message-ID: <20160831140630.GG12660@htj.duckdns.org> References: <20160830163428.GA25978@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160830163428.GA25978@Karyakshetra> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2016 at 10:04:28PM +0530, Bhaktipriya Shridhar wrote: > The workqueue "creg_wq" queues a single work item viz > &card->creg_ctrl.done_work and hence it doesn't require execution > ordering. Hence, alloc_workqueue has been used to replace the > deprecated create_singlethread_workqueue instance. > > The workqueue "event_wq" queues a single work item viz &card->event_work > and hence it doesn't require execution ordering. Hence, alloc_workqueue > has been used to replace the deprecated create_singlethread_workqueue > instance. > > The WQ_MEM_RECLAIM flag has been set in both cases to ensure forward > progress under memory pressure. > > Since there are a fixed number of work items, explicit concurrency > limit is unnecessary here. > > Signed-off-by: Bhaktipriya Shridhar Acked-by: Tejun Heo Thanks. -- tejun