From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964887AbcHaO2t (ORCPT ); Wed, 31 Aug 2016 10:28:49 -0400 Received: from mail-yb0-f196.google.com ([209.85.213.196]:33328 "EHLO mail-yb0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935017AbcHaO2n (ORCPT ); Wed, 31 Aug 2016 10:28:43 -0400 Date: Wed, 31 Aug 2016 10:28:40 -0400 From: Tejun Heo To: Bhaktipriya Shridhar Cc: David Howells , Mark Fasheh , Joel Becker , Michal Hocko , Johannes Weiner , Vladimir Davydov , "Kirill A. Shutemov" , "David S. Miller" , Eric Dumazet , Andrew Morton , Joseph Qi , "Norton.Zhu" , Jun Piao , xuejiufei , ocfs2-devel@oss.oracle.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/9] fs/afs/flock: Remove deprecated create_singlethread_workqueue Message-ID: <20160831142840.GQ12660@htj.duckdns.org> References: <8c5c16439daeacf757885daa5ad6baa7d9415afc.1472578959.git.bhaktipriya96@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c5c16439daeacf757885daa5ad6baa7d9415afc.1472578959.git.bhaktipriya96@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2016 at 11:15:28PM +0530, Bhaktipriya Shridhar wrote: > The workqueue "afs_lock_manager" queues a single work item > &vnode->lock_work, and hence it doesn't require execution ordering. > Hence, alloc_workqueue has been used to replace the deprecated > create_singlethread_workqueue instance. > > The WQ_MEM_RECLAIM flag has been set to ensure forward progress under > memory pressure because the workqueue is being used on a memory reclaim > path. > > Since there are fixed number of work items, explicit concurrency > limit is unnecessary here. > > Signed-off-by: Bhaktipriya Shridhar For all afs patches, Acked-by: Tejun Heo Thanks. -- tejun