From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964821AbcHaObs (ORCPT ); Wed, 31 Aug 2016 10:31:48 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:35025 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933835AbcHaObr (ORCPT ); Wed, 31 Aug 2016 10:31:47 -0400 Date: Wed, 31 Aug 2016 10:31:40 -0400 From: Tejun Heo To: Bhaktipriya Shridhar Cc: Mark Fasheh , Joel Becker , Andrew Morton , Joseph Qi , xuejiufei , "Norton.Zhu" , Jun Piao , "David S. Miller" , Eric Dumazet , Michal Hocko , Vladimir Davydov , Johannes Weiner , "Kirill A. Shutemov" , ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] fs/ocfs2/dlm: Remove deprecated create_singlethread_workqueue Message-ID: <20160831143140.GU12660@htj.duckdns.org> References: <2b5ad8d6688effe1a9ddb2bc2082d26fbbe00302.1472590094.git.bhaktipriya96@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2b5ad8d6688effe1a9ddb2bc2082d26fbbe00302.1472590094.git.bhaktipriya96@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2016 at 02:21:26AM +0530, Bhaktipriya Shridhar wrote: > The workqueue "dlm_worker" queues a single work item &dlm->dispatched_work > and thus it doesn't require execution ordering. Hence, alloc_workqueue > has been used to replace the deprecated create_singlethread_workqueue > instance. > > The WQ_MEM_RECLAIM flag has been set to ensure forward progress under > memory pressure. > > Since there are fixed number of work items, explicit concurrency > limit is unnecessary here. > > Signed-off-by: Bhaktipriya Shridhar Just for the record, Acked-by: Tejun Heo Thanks. -- tejun