From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Steve Muckle <steve.muckle@linaro.org>,
Ingo Molnar <mingo@redhat.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Juri Lelli <Juri.Lelli@arm.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Steve Muckle <smuckle@linaro.org>
Subject: Re: [PATCH 1/2] sched: cpufreq: ignore SMT when determining max cpu capacity
Date: Wed, 31 Aug 2016 16:34:37 +0200 [thread overview]
Message-ID: <20160831143437.GW10121@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <2411837.FJm8ec21FH@vostro.rjw.lan>
On Wed, Aug 31, 2016 at 03:27:30AM +0200, Rafael J. Wysocki wrote:
> On Friday, August 26, 2016 11:40:47 AM Steve Muckle wrote:
> > PELT does not consider SMT when scaling its utilization values via
> > arch_scale_cpu_capacity(). The value in rq->cpu_capacity_orig does
> > take SMT into consideration though and therefore may be smaller than
> > the utilization reported by PELT.
> >
> > On an Intel i7-3630QM for example rq->cpu_capacity_orig is 589 but
> > util_avg scales up to 1024. This means that a 50% utilized CPU will show
> > up in schedutil as ~86% busy.
> >
> > Fix this by using the same CPU scaling value in schedutil as that which
> > is used by PELT.
> >
> > Signed-off-by: Steve Muckle <smuckle@linaro.org>
>
> This is fine by me.
>
> Peter, any objections?
No, looks good. Thanks
next prev parent reply other threads:[~2016-08-31 14:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 18:40 [PATCH 0/2] utilization changes for schedutil Steve Muckle
2016-08-26 18:40 ` [PATCH 1/2] sched: cpufreq: ignore SMT when determining max cpu capacity Steve Muckle
2016-08-31 1:27 ` Rafael J. Wysocki
2016-08-31 14:34 ` Peter Zijlstra [this message]
2016-09-12 22:25 ` Rafael J. Wysocki
2016-08-26 18:40 ` [PATCH 2/2] sched: cpufreq: use rt_avg as estimate of required RT CPU capacity Steve Muckle
2016-08-31 1:31 ` Rafael J. Wysocki
2016-08-31 14:49 ` Steve Muckle
2016-08-31 14:39 ` Peter Zijlstra
2016-08-31 15:08 ` Steve Muckle
2016-08-31 16:28 ` Thomas Gleixner
2016-08-31 16:40 ` Peter Zijlstra
2016-08-31 17:00 ` Juri Lelli
2016-09-01 7:12 ` Peter Zijlstra
2016-09-01 21:48 ` Steve Muckle
2016-09-02 9:35 ` Juri Lelli
2016-09-02 12:17 ` Thomas Gleixner
2016-08-31 22:50 ` Rafael J. Wysocki
2016-09-02 8:12 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831143437.GW10121@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Juri.Lelli@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=smuckle@linaro.org \
--cc=steve.muckle@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome