From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935292AbcHaOlC (ORCPT ); Wed, 31 Aug 2016 10:41:02 -0400 Received: from mail-yw0-f169.google.com ([209.85.161.169]:34224 "EHLO mail-yw0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933887AbcHaOlB (ORCPT ); Wed, 31 Aug 2016 10:41:01 -0400 Date: Wed, 31 Aug 2016 10:40:54 -0400 From: Tejun Heo To: David Howells Cc: Bhaktipriya Shridhar , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue Message-ID: <20160831144054.GW12660@htj.duckdns.org> References: <26365.1472595343@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26365.1472595343@warthog.procyon.org.uk> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2016 at 11:15:43PM +0100, David Howells wrote: > Bhaktipriya Shridhar wrote: > > > The workqueue "afs_async_calls" queues a single work item viz > > &call->async_work and hence it doesn't require execution ordering. > > ... > > Since there are fixed number of work items, explicit concurrency > > limit is unnecessary here. > > There can be more than one single call and there's no fixed number. > > > The workqueue "afs_lock_manager" queues a single work item > > &vnode->lock_work, and hence it doesn't require execution ordering. > > ... > > Since there are fixed number of work items, explicit concurrency > > limit is unnecessary here. > > There may be more than one single vnode and there's no fixed number. Ah, okay, the work items are dynamically allocated. Do they need strict execution ordering or can they be executed concurrently? Thanks. -- tejun