From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, netdev@vger.kernel.org
Subject: Re: [RT PATCH 1/2] net: add back the missing serialization in ip_send_unicast_reply()
Date: Wed, 31 Aug 2016 18:36:14 +0200 [thread overview]
Message-ID: <20160831163613.dg5hgb6l2jd5b5ms@linutronix.de> (raw)
In-Reply-To: <20160831121553.6aea5cda@gandalf.local.home>
On 2016-08-31 12:15:53 [-0400], Steven Rostedt wrote:
> > @@ -689,10 +691,13 @@ static void tcp_v4_send_reset(const struct sock *sk, struct sk_buff *skb)
> > offsetof(struct inet_timewait_sock, tw_bound_dev_if));
> >
> > arg.tos = ip_hdr(skb)->tos;
> > +
> > + local_lock(tcp_sk_lock);
>
> Interesting that I noticed in mainline, they have:
>
> local_bh_disable();
>
> here.
>
> I'm surprised we don't have a local_lock_bh() or something to that
> effect.
Turning local_bh_disable() into local_lock_bh(). One side effect would
be that the network driver will be flushed out / waited for completion
during socket write (due to the spin_lock_bh()). Not sure how much fun
all this will bring.
We could try this…
> -- Steve
Sebastian
prev parent reply other threads:[~2016-08-31 16:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 16:00 Sebastian Andrzej Siewior
2016-08-31 16:00 ` [RT PATCH 2/2] net: add a lock around icmp_sk() Sebastian Andrzej Siewior
2016-08-31 16:37 ` Eric Dumazet
2016-08-31 17:03 ` Steven Rostedt
2016-09-01 8:11 ` Sebastian Andrzej Siewior
2016-09-01 13:11 ` Eric Dumazet
2016-08-31 16:15 ` [RT PATCH 1/2] net: add back the missing serialization in ip_send_unicast_reply() Steven Rostedt
2016-08-31 16:36 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831163613.dg5hgb6l2jd5b5ms@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®