From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933655AbcIAQsS (ORCPT ); Thu, 1 Sep 2016 12:48:18 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34532 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932307AbcIAQsO (ORCPT ); Thu, 1 Sep 2016 12:48:14 -0400 Date: Thu, 01 Sep 2016 09:48:13 -0700 (PDT) Message-Id: <20160901.094813.947883991894136945.davem@davemloft.net> To: Yuval.Mintz@qlogic.com Cc: fengguang.wu@intel.com, kbuild-all@01.org, netdev@vger.kernel.org, Ariel.Elior@qlogic.com, Dept-EngEverestLinuxL2@qlogic.com, linux-kernel@vger.kernel.org, Sudarsana.Kalluru@qlogic.com Subject: Re: [PATCH] qed: fix kzalloc-simple.cocci warnings From: David Miller In-Reply-To: References: <201609011409.GGSqCknq%fengguang.wu@intel.com> <20160901064512.GA49421@lkp-sb04> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 01 Sep 2016 09:48:14 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yuval Mintz Date: Thu, 1 Sep 2016 07:37:13 +0000 >> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1230:13-20: WARNING: kzalloc >> should be used for dcbx_info, instead of kmalloc/memset >> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1192:13-20: WARNING: kzalloc >> should be used for dcbx_info, instead of kmalloc/memset >> >> >> Use kzalloc rather than kmalloc followed by memset with 0 >> >> This considers some simple cases that are common and easy to validate Note in >> particular that there are no ...s in the rule, so all of the matched code has to be >> contiguous >> >> Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci >> >> CC: Sudarsana Reddy Kalluru >> Signed-off-by: Fengguang Wu > > This looks fine; But what's the right process here - > Dave - do we need to re-post this with the the right 'destination' in title > [net/net-next]? Or is it good as-is? > In case of latter, > Acked-by: Yuval Mintz I'll apply this as-is, thanks.