From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751378AbcIBFsU (ORCPT ); Fri, 2 Sep 2016 01:48:20 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:44978 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbcIBFsR (ORCPT ); Fri, 2 Sep 2016 01:48:17 -0400 Date: Thu, 01 Sep 2016 22:45:23 -0700 (PDT) Message-Id: <20160901.224523.434756920053712480.davem@davemloft.net> To: fgao@48lvckh6395k16k5.yundunddos.com Cc: tom@herbertland.com, aduyck@mirantis.com, amir@vadai.me, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, gfree.wind@gmail.com Subject: Re: [PATCH v2 net] rps: flow_dissector: Fix uninitialized flow_keys used in __skb_get_hash possibly From: David Miller In-Reply-To: <1472624105-5163-1-git-send-email-fgao@ikuai8.com> References: <1472624105-5163-1-git-send-email-fgao@ikuai8.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 01 Sep 2016 22:45:24 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: fgao@ikuai8.com Date: Wed, 31 Aug 2016 14:15:05 +0800 > From: Gao Feng > > The original codes depend on that the function parameters are evaluated from > left to right. But the parameter's evaluation order is not defined in C > standard actually. > > When flow_keys_have_l4(&keys) is invoked before ___skb_get_hash(skb, &keys, > hashrnd) with some compilers or environment, the keys passed to > flow_keys_have_l4 is not initialized. > > Fixes: 6db61d79c1e1 ("flow_dissector: Ignore flow dissector return value from ___skb_get_hash") > > Acked-by: Eric Dumazet > Signed-off-by: Gao Feng Applied.