mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Morten Rasmussen <morten.rasmussen@arm.com>
To: peterz@infradead.org, mingo@redhat.com
Cc: dietmar.eggemann@arm.com, yuyang.du@intel.com,
	vincent.guittot@linaro.org, mgalbraith@suse.de,
	sgurrappadi@nvidia.com, freedom.tan@mediatek.com,
	keita.kobayashi.ym@renesas.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/5] sched: Clean-ups and asymmetric cpu capacity support
Date: Thu, 1 Sep 2016 09:33:12 +0100	[thread overview]
Message-ID: <20160901083311.GA9409@e105550-lin.cambridge.arm.com> (raw)
In-Reply-To: <1472640739-8778-1-git-send-email-morten.rasmussen@arm.com>

On Wed, Aug 31, 2016 at 11:52:14AM +0100, Morten Rasmussen wrote:
> v4:
> 
> - Removed patches already in tip/sched/core.

Just discovered an error on the comment of one of those patches :-/

----8<----

>From a0040f8dfe60696d7e6429f50906d6b17671bbcc Mon Sep 17 00:00:00 2001
From: Morten Rasmussen <morten.rasmussen@arm.com>
Date: Thu, 1 Sep 2016 09:24:35 +0100
Subject: [PATCH] sched/fair: Fix wrong comment for capacity_margin

The comment for capacity_margin introduced in "sched/fair: Let
asymmetric cpu configurations balance at wake-up" got its usage the
wrong way round.

cc: Ingo Molnar <mingo@redhat.com>
cc: Peter Zijlstra <peterz@infradead.org>

Signed-off-by: Morten Rasmussen <morten.rasmussen@arm.com>
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 27534e36555b..161fd8eba234 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -116,7 +116,7 @@ unsigned int sysctl_sched_cfs_bandwidth_slice = 5000UL;
 
 /*
  * The margin used when comparing utilization with CPU capacity:
- * util * 1024 < capacity * margin
+ * util * margin < capacity * 1024
  */
 unsigned int capacity_margin = 1280; /* ~20% */
 
-- 
1.9.1

      parent reply	other threads:[~2016-09-01  8:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-31 10:52 Morten Rasmussen
2016-08-31 10:52 ` [PATCH v4 1/5] sched/fair: Compute task/cpu utilization at wake-up correctly Morten Rasmussen
2016-08-31 10:52 ` [PATCH v4 2/5] sched/fair: Consider spare capacity in find_idlest_group() Morten Rasmussen
2016-08-31 10:52 ` [PATCH v4 3/5] sched: Add per-cpu min capacity to sched_group_capacity Morten Rasmussen
2016-08-31 10:52 ` [PATCH v4 4/5] sched/fair: Avoid pulling tasks from non-overloaded higher capacity groups Morten Rasmussen
2016-08-31 10:52 ` [PATCH v4 5/5] sched/fair: Track peak per-entity utilization Morten Rasmussen
2016-09-01 11:51   ` Patrick Bellasi
2016-09-01 12:43     ` Morten Rasmussen
2016-09-01  8:33 ` Morten Rasmussen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160901083311.GA9409@e105550-lin.cambridge.arm.com \
    --to=morten.rasmussen@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=freedom.tan@mediatek.com \
    --cc=keita.kobayashi.ym@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgalbraith@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=sgurrappadi@nvidia.com \
    --cc=vincent.guittot@linaro.org \
    --cc=yuyang.du@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®