From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752585AbcIAWEQ (ORCPT ); Thu, 1 Sep 2016 18:04:16 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47876 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752176AbcIAWEM (ORCPT ); Thu, 1 Sep 2016 18:04:12 -0400 Date: Thu, 1 Sep 2016 18:02:15 +0100 From: Mark Brown To: Andy Shevchenko Cc: "linux-kernel@vger.kernel.org" , "Hunter, Adrian" Message-ID: <20160901170215.GJ5967@sirena.org.uk> References: <1472741623.4887.482.camel@linux.intel.com> <20160901153836.GI5967@sirena.org.uk> <1472746516.4887.489.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LG0Ll82vYr46+VA1" Content-Disposition: inline In-Reply-To: <1472746516.4887.489.camel@linux.intel.com> X-Cookie: Beware of computerized fortune-tellers! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: Regulator probe X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --LG0Ll82vYr46+VA1 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 01, 2016 at 07:15:16PM +0300, Andy Shevchenko wrote: > On Thu, 2016-09-01 at 16:38 +0100, Mark Brown wrote: > > On Thu, Sep 01, 2016 at 05:53:43PM +0300, Andy Shevchenko wrote: > > The device isn't registered and it's saying it isn't registered, this > > is > > normal.=A0=A0Since this is an ACPI system > Nope, it's SFI. Which basically means we have everything in board files. Ugh, I'd been assured that SFI had been killed off :( Anyway if that's the case then it should all be working already then unless SFI goes down the ACPI code paths or someone changed SFI since SFI won't flag as having full costraints and therefore any missing regulator will report as deferring. If that is indeed the case you've probably got a broken consumer driver that's not handing probe deferrals. > > we are expecting the firmware or > > whatever else registers devices and their supplies to do that, if the > > supplies aren't being mapped at device registration time then you're > > telling the core not to expect any.=A0=A0If you had mapped the supply a= nd > > it > > wasn't available the consumer would get an -EPROBE_DEFER. > Basically you mean we have not call regulator_has_full_constraints()? > In that case we have to provide stubs for all expected regulators, in > case of SDHCI one real and one dummy, who knows how many them in the > drivers, but for each we have to provide that. Am I right?=A0 You have to either not call regulator_has_full_constraints() or supply all the mappings for device supplies before you register a device. If you don't call regulator_has_full_constraints() missing regulators will always defer so you would need to provide a fixed voltage regulator for it. If it's really absent you'll need to provide full constraints, we can't tell otherwise. > > As I keep saying with all these problems if you want to reimplement DT > > instead of using it you need to reimplement *all* of DT, it's there > > for > > a reason.=A0=A0It would be a lot quicker and simpler to just use DT for > > these systems. > Here we have platform code. It might be possible to switch to DT for it, > with no firmware support, but I can consider it as a far away from now. It would be a lot more sensible than SFI, it's so limited you're basically just using board files but with the limitations of having to do bits of it through firmware and then join the two up which seems like the worst of both worlds. --LG0Ll82vYr46+VA1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXyF8WAAoJECTWi3JdVIfQ4YIIAIX0UryplkjFcK82EqEHPhv/ MEAl664uT0/LpN3YjcZ4RawMRgopjHzeERAP9Iahq1quKgotK6j7eqdPpXm6UlM1 iWZS3XwbpkvC4X599FKvY2fR0qpaIE4ZSxlD4Bc50z+oUxqxvgOKmDEdwcIfdfdM Z4D+d5l2ErjHrGJfoAvmqpffflLazlxS0FW7KqcanSzsdQUF/aFLYI+6jkvwP32z ftg1ZDfIVsWYPt4MW561eyxNrG3I0jbStoj/d0EJXmZrS5v7WDvZztdwLfuoDctx nPiCKvW7+cDY5gmmo8lgmPdLVj0hoFKgeMq9EGylZoCWpbuESjijOd2HU7tYVsw= =x2Mg -----END PGP SIGNATURE----- --LG0Ll82vYr46+VA1--