From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752170AbcIBBcT (ORCPT ); Thu, 1 Sep 2016 21:32:19 -0400 Received: from mail-bl2nam02on0046.outbound.protection.outlook.com ([104.47.38.46]:8590 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751951AbcIBBcP (ORCPT ); Thu, 1 Sep 2016 21:32:15 -0400 X-Greylist: delayed 14365 seconds by postgrey-1.27 at vger.kernel.org; Thu, 01 Sep 2016 21:31:31 EDT Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Date: Thu, 1 Sep 2016 10:56:36 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Nava kishore Manne CC: , , , , , , , , , , , Nava kishore Manne Subject: Re: [PATCH v5] Axi-usb: Add support for 64-bit addressing. Message-ID: <20160901175636.GV16583@xsjsorenbubuntu> References: <1472719976-25410-1-git-send-email-navam@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1472719976-25410-1-git-send-email-navam@xilinx.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22548.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(24454002)(199003)(377424004)(189002)(9786002)(1076002)(47776003)(77096005)(81156014)(85182001)(8676002)(81166006)(92566002)(8936002)(76176999)(2906002)(23676002)(7846002)(33716001)(7416002)(5660300001)(76506005)(305945005)(4001450100002)(57986006)(626004)(2950100001)(63266004)(4326007)(50466002)(4001430100002)(107886002)(33656002)(106466001)(189998001)(4001350100001)(110136002)(85202003)(54356999)(87936001)(36386004)(2870700001)(9686002)(19580405001)(586003)(83506001)(19580395003)(50986999)(356003)(18370500001)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR02MB1140;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1NAM02FT033;1:eWgIrIFM4JlBX4jPTBtkXbSBLiwhSx9qNtq/VYlxZMQEg30DsrhFls+hRO4xrL27ikMwwJRvV9EdwLRE76H7wu/1O98gCdz4h/IOcB4rbVE2mzdsTWiZEexF7QANPLCNSwrU02o3QBRdUHoWDq+RWtpZC4IDadPFFon2Rp8oN16rPaNwwZhhc0NrALnEBd7vst6v7Ajqfx/7kc5aB2fVU+iz8xxywEBaYAmmuLjcHJP5sId9HLXi5c1O/XswrlMqUiK4jow1W4C0XUUFANZvHMnPP9ABa5lGpkNj6UcdD2oTQyfyqW8yAbS7Sk1xaYa7IVVwshDZPOcIr4iLGMOgdtkLh21nwtxIhRNPSwD1oUOGhQz43ik+lVU3HdKAzlWVu8AEMhf6Tmf2FlxsPKo98GJNhs9tm7e6BBJT/2LgvT6q4TlyIZpmb8+xABdPKY02tEowwlxSduaWSym6bkr0XBwo58PV1TM5KsjDZwvvP4hVU0h6/Mm22v5vvTTV0HNIxfRT7PXJ0IcPcJh6Hf1o5kLJS5dO7Rcewg1wvqtkRkphLMUulSlcuhFc4obuQ8XtTFaMeUDwghFO7RtETOj8GXIJExq/9TfxMKCBult5MWHgS3zXZ9yq4Y5oSTs1dmYw X-MS-Office365-Filtering-Correlation-Id: 2087abcb-2986-4eb8-aa93-08d3d29164de X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB1140;2:hI1E+M024EEV6UBKCDWvgJ/88/Xm9iKdhKskjO7QBmR9d1HP8H5zuhGIt2e/LZX2JTFNxZvSEcVfB1DXhoJq5eAvm77wl/S1VF6Sy3g4es6IppgkqqcAk/m/LkBGWsN9271vMYEPpUmc0e51nikabll798uMKfEh2I3uIYEnKdO0EJLF24BM/0J+CPeazHYU;3:wpHZlC81CfbQcamY0zwEk7yVveNOinPDs2xmcYWAVzCgKyXWoy6QEZrG56KwKdkaAJN1L4BOV9mXo2tsRIyp3hbfePVtswaByUNIwMENpaf0MMAVXNJ7lzwz41kBAwz3vxiB3aaOyZrnOBdH92Hm34mCB0gfQH86QVHhwn8HQr/RckdFZ4Fx8M2kJRudrpVc1lrAQXt5fyLj7T7WJJ3NaoS/mH32mi/3nYLkHRD+oeTsQyN9F5Y+RPSIZnexCssFIWkAQq99PIsTQiDa96FhBA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BLUPR02MB1140; X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB1140;25:BLZzBmsioaK+P90WVx72D8W9Jr4YA2fsf8am8m/b1zTcDyPtBhnB01RjJWOt/rSlKNxOy9sUnvSdaRc9PgF5zQ80z/TYFIg6Ja8xHgTPvrFPyeMqomijyoodAje0LTjZAi+lPRjFnUe5AQIzzsj/kLSLLfe1KyvwXIeR5QW18fxo7biTCs/ZCZQvzttpA4fUsqaEp6UQkrRoGeCRPzU7r4VAPRvft3LawQbpQk/cc9goyz+IBv7l9f1d9WsGOqrKUF60lafNdByiovSjgeQUySwtksaHh27MNCAw9gefMh8jsIengKu2OSuuJ47yJRI10EHDDJjqie+SURmfEfX83GzyckRgIXmlLJG+mC7Jh98w/XwWY5VJYM2HPcrZTc3soF9h69xDHnmJJdWEvcAjp4m9mFdw2/UL8dPfCTYg02ElTYXRKIKiSJD2iLwYC4BwIA8skMrLGDoX9TkfchAboVUXVybCjn06iuaU34qPuOK6aQIP2WEl62lf96ASpJIqQHhgVuLKo/v/1IufjoALREG31Pfj5yTG/+RLGqoaG3D2E3KV5KefYPFgH4iX6TWXJC7aBf1uN0SlsU8j+CyUkqyW38CfXfk/34nbbQpe3h64XE+XUaRWEtoavo/hgJUM5rf+Wflv3PY6jz5rOtDrNWCrl9Vq8obzsFIHM4QlIoitzgDPtV7nFVZ/T78D3K+WxBAOAkAqnHSfH1q2DFKr3faXxqtbLr1lkiaNelL7eMIfeb221qD5foC1afjUBqVxRUaD/dqyIZLVjT9y39Uk+T6Us+WHcg+zcADYqtJDXJo= X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB1140;31:3gOn/5TNRdHQ2UObEOaK1kPA5nmPNhhqWxQYvhw4Sfm5wF0RHmFkkum4XXzZwfRX9wILEXbHDdY7lKjZildBPS3fXkMPR0YLDh3NwsIShok1c05XUW1Az8qkTOoftYiADTCilsEmlIfrbcM8Ce4lse72YIRTU0GSxHYvvOPX1oiQVfst+g2n8L9aQhkHj+Z64SSm4hiI2TLizSTpQNHkyeE8NZzv4IubPKiRUXZCeIo=;20:RS5Imv98kZ45gXPgY+dOMESE7TTHpGjQN/bxzXgEBHSpqQE49BVgi5gucHKBko3MFIt0IZK2aNGoyRerfGogihjo2r3zeGfDYiybSyMuUpDTsmi+mJkdWQs1BOCf8lZXJ/QfjSNBPhw5YpulfEdEMXQFsRSRgTr1nzfCrUax4p60/IEGeEI0F8RhwoFx1HjXWWXGSlNjTj329DgD19Y4wAp9/m2Rw7WznQZU/n3PGJIUdUJSBzSpFAd9o+Wd8afckzkaO5x8SzZ+nnemMZ6pKtwIax094RMLEFBSD8mUCBgbzRpXAbYVSejYWNC/3ow0i3XDPY7F14qB5C2Hg91IbC0PvOHZQvinmDDNu3Ptrl0MUIxwF9HP7cAxnM+tXbFR4w8BQZ5h3LfqVWYLjqq4gHVFbgfquyf0Dd9W8nlXw94oAxt5ekBH9P1wcY8ZQ+WAfYD6YjGeyHRSV4D6vri/80vUI055oOVRGA7iNDkFAUaVmqUIgJN75cJKTe8hWi6n X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(13017025)(13015025)(13018025)(13023025)(13024025)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:BLUPR02MB1140;BCL:0;PCL:0;RULEID:;SRVR:BLUPR02MB1140; X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB1140;4:D26GuhHQhFUTcgofuSHKuTg8bliR1f5g8jHHesMmoeuj8xKntCG2Btzr0LLYrHZlZ/ZwtIFtTXBhgvvpSmyOUjLnUN5yjIe05HoBdxu3Spyz9Ct7QBkf2P/btJZDUUx20m3xG5JKxpwdtjOPUCST9bGu094RJ2IQkjNGmpIokgo8TNSvgl4r7aflkhcP5YWlgn+RBq+wtRSnz/+5grA7143ledrrxKGYUHWicTLrsNnW65bq7qOo02DaV1FogaRCe8knHCXaZ7nvqoD6nBZBXwmmNB1BbHo/oEuqCDG/Fvvadp1Suwqo2zXKxbwzZhDuJC6iQjOALye+/W9/kBHVvBgR2JA2D6XSFEEMdSQz3gsOYLoxXg2yQR4La4epcDhxSsjNMyBLE3yw/IK5fw2/vqcxzvq10/bw1DLx1Dh3ujvSTtOPYQdD6CZA+8r7VrbsZoYToyCtu34pE6Ew03MAdT3lQyogVhMkBRrLyB9pFzX+0oBfMiLTJ2da89A9qLii+ESu7FRPCTD02k1HdQLMNmXWbHJTJbcD2dGgF0iCRX0= X-Forefront-PRVS: 0052308DC6 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjAyTUIxMTQwOzIzOjNDWjlMT3BERXJBNHRmUU41QXY2NGlVK21j?= =?utf-8?B?K1JZZ0pmK09TMHcyTjhKaG1DSzZRTTdOZzZnSnlqazdTS1p6RkR6SFowOUdD?= =?utf-8?B?YmRuZXh3K1NBREF1M3NSQzJyamhPSC9qMFgzeG52ME5vQmhobDJYV3Q0TFR5?= =?utf-8?B?SStIb2dPQU1HQ09IbHJLM1NWTHMwb2k5NVpHMTFzT2pudDZEaFViRFRoVDll?= =?utf-8?B?QS91V1MwWnY4SjNabE1wMnRWK0V6ZEIyVlgvSjhNcnFzamlIZ2VWdjJxZnIr?= =?utf-8?B?L3hxU1FKMEpzMzZYVXNxTFZwbENFdHM1L2xYRWNuaEFjeTVXQVZQT2lMOWps?= =?utf-8?B?NEp6UHRYTUtDZVVvaTQzYjhXbDVpaUxHT29PNHlkOTA0SjRWTGFlSWRrQnZP?= =?utf-8?B?aXJZSy9TREJhVms5Tkdob2RqeWMrL1dXbXJJaUxVM3E1UkJ0R3dOcmk1ZGdp?= =?utf-8?B?QUlKWEJJZzdSb1Y4ZUUwTDVPSmRxa3NSSS9ZU2haRmp1OUZOU3h5K1BXV2lt?= =?utf-8?B?R0tFdVlOL3BuYm5RMkJxSUYwVnphUFMrV3M3KzJLR2k1Vm9WdVdYZERkamtz?= =?utf-8?B?bHZ3TTFFUGxrUUFkQ3ZHVjhPTlhuaWVPZWhTM0FFbXZOcnkza0k4R0o1a2x0?= =?utf-8?B?RUdZME1xVjlnaHJ0dzBMb3Vpa1I0K3l4bURjODFVRk1xNVMvSFBUR3RRc2JH?= =?utf-8?B?TU5wdmhXUFZqaFZYNXFOZDBHOHZoZ1NrNE1jemZveTA0MGhyQ01UcS8rU3Ba?= =?utf-8?B?Skh0dmRYZHBET0YzWGNIcnhHRHcybmJnZVRCZnc3YXZNeGxQMUd3Z2Z3WEpL?= =?utf-8?B?Rm91ME85YjNteER2bzZob1dVdFMwU0IrRkc0bUQyY3krSzBIdGJJZXhEUkRz?= =?utf-8?B?TFd2RXVHZ1QyTjN2Qzl4bVUzSS90U0ltdXVYMHdGbGdwaTNKKzB4WjI2MWZV?= =?utf-8?B?RFNHMjA1NkR0OWk3UStYd09PZ3QxWWRFMXJ2S2pzSkVvZDhlSlpQSTQvMHpp?= =?utf-8?B?UVlzQ2pETHRzN1NFZk5sMXZIMjBvcTFNaU02d0VwUWszYUdaeXIyMzVhdS9W?= =?utf-8?B?MXJIdldhVTYyMW52YW4xekhWZGhoTWg2TXNVWEhaWTlpdjRnNFF3K3g1T21H?= =?utf-8?B?V2dYdTZ0d0ZMUWd2WUNHZnRtQUZYcTBIc2RJVmJvRE9vM2p3SFdFMy91Rzhq?= =?utf-8?B?K1UweU04RVA3bExzU0t3UVNnejJvWkpFcFhnb3Q0QitFUFRkRmo3RElQbksy?= =?utf-8?B?QnY1SzJ4YStidWpoUjFscnBSb0ZDM3lsb2FGRkFUNDBXMlVCMkpsQzBaTXpm?= =?utf-8?B?RUczV2NzYzJJRGxYbnVrdVlEeFFqdklxTjRwSTRvV2dXSG1yeFRVYUlSUFZz?= =?utf-8?B?UFl2aHI2S0JuRjVZK3hDdUthdnFSVEgremxGRUM5NkhkT0x1YWdvV2c1cVpk?= =?utf-8?B?MHpOeGxqaXhnbTdqb3VDNEJQanIzcHZRTmc3K2IraE5CN2VjTnNMYnd5REpp?= =?utf-8?B?U3dQMkNnYWZORTVQbGhmdjhOQ1RvT0VXSlo2ajVqb1ljNzNaQ2lrN081S1g3?= =?utf-8?B?d2tpQ0RkQ1J5dVZncjRYdUludE1hcWVoZHlaMzNQYXp4NURnMUxEMVFDSnFq?= =?utf-8?B?enlUek8zbkVaTDBISFROWk5mZlBCVnhEU0I5TnFrVVA1K05MemI2RVNWRjBT?= =?utf-8?B?aU15cUlZYnpNV0kxUkg5bDRCcVBzdFBjYlVkQUJNajloYmF1UFZMSlUxWXhu?= =?utf-8?B?bUF1eHB1RmRxZlBydmxpWkhqbmcxelRMcy9DT3crU2c0d3A0ZlRwb0JYcTJ3?= =?utf-8?B?dzFhV2RrT2VPenMrVnc0cnF5diswR2FVZGVOcFFuK2srdXc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB1140;6:FaCLn/sBWISW+NiQs0zswSVg1FrzBYQ6XDv33DXbcxYsGfDDwSFPy/IhBCVTVP73jliWhj23TXuxDnMaH3C/KG97idfqgnEtud5jOEP8jyojflBRS3tbaKci4U3EC2U9g2jPVCsO2LFo3UL9U0oRrxetH9m1X4uTdZCAEApQjgbilF+9rXDOwmsnPFIVJMGtGVBHX/QjgdwWQ7LAmfKux6VUlN5M9oYypnxsayMQSKRCyo79/lbz+IFMfsac+VjTjS+5G9q+4GnoSd59VEA06mJM5wU0nQwFl+zpbIM1VPjIHG6YLltC844BbJ3oKOPtbpe5XmqHEjYGkmaXMEkmrg==;5:2vGGN9CFGZ4za+TJBt2vhLJK0nhnHcGJgJstrJ7NVPvYGZifeJYMJlEk21w6eABXR2Cox48kEkHsUyvrnSJX7egViw+5zV/4DDRNL0PIds8qdIfnQQIqyLqSgfoTyHRdmdHtmM3Is9wUCakBVoOb1g==;24:CCKYLNitcs1utygxKsyN91UYintYVqyfdg3OP5/ZxSef7IqQa434I3vEnxDIfW0Wb7eLzJdx8lKB36eRSj3gLIA4eI0eUOBXeUPteLkQNAQ=;7:oNOluPO+Rq/odrhBRkf783LmYMgmXtn+TLYFUb+Hey9wS/jG8fjWUywdVSkr47mul3yLEk9uzu+RRHZJhWdmyb4Uz/Y5p7mW76wIrhRci4leYsREU8EuD3xNb7E+wHquBcRyYPoYkuFK9KFBCd+wyjsO7UqIFvQT6brmlri0P4FtJy77/t9EnuNOfLfHEhYPqH+SVYMahOZS4QWoIQHdHUCcu/XtAHpCowQRxXdneWNRJzqNzgs3tKm4b0OFk1BC SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2016 17:57:08.8933 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR02MB1140 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-09-01 at 14:22:56 +0530, Nava kishore Manne wrote: > This patch updates the driver to support 64-bit DMA addressing. > > Signed-off-by: Nava kishore Manne > Acked-by: Rob Herring > --- > Changes for v5: > -None. > > Changes for v4: > -Used boolen property insted of addrwith property in the DT > as suggested by Arnd Bergmann. > -Adopt the DT relevant changes into the driver. > > Changes for v3: > -Added new compatable string for 5.00 IP version as suggested by > Arnd Bergmann. > -Used write_fn() insted of lo_hi_writeq() as suggested by > Arnd Bergmann. > Changes for v2: > -Added dma-ranges property in device tree as suggested by > Arnd Bergmann. > -Modified the driver code based on the xlnx,addrwidth. > > .../devicetree/bindings/usb/udc-xilinx.txt | 5 ++- > drivers/usb/gadget/udc/udc-xilinx.c | 52 +++++++++++++++++++++- > 2 files changed, 54 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/udc-xilinx.txt b/Documentation/devicetree/bindings/usb/udc-xilinx.txt > index 47b4e39..d08d972 100644 > --- a/Documentation/devicetree/bindings/usb/udc-xilinx.txt > +++ b/Documentation/devicetree/bindings/usb/udc-xilinx.txt > @@ -1,12 +1,14 @@ > Xilinx USB2 device controller > > Required properties: > -- compatible : Should be "xlnx,usb2-device-4.00.a" > +- compatible : Should be "xlnx,usb2-device-4.00.a" or > + "xlnx,usb2-device-5.00" > - reg : Physical base address and size of the USB2 > device registers map. > - interrupts : Should contain single irq line of USB2 device > controller > - xlnx,has-builtin-dma : if DMA is included > +- xlnx,has-64bit-dma : if DMA is included 64-bit addressing support. We add these properties to describe the IP configuration + we have the version indicator in the compatible string. Do we really need both? It seems that all versions use the same driver and differentiation is made through the DT properties that describe the IP configuration parameters. Wouldn't it be better to just have one generic 'xlnx,axi-usb2' (or whatever) compatible string instead of patching the driver for each new version without really needing to differentiate the IP versions through it? Sören