From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756675AbcIAVHA (ORCPT ); Thu, 1 Sep 2016 17:07:00 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47626 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756609AbcIAVGx (ORCPT ); Thu, 1 Sep 2016 17:06:53 -0400 Date: Thu, 1 Sep 2016 20:51:06 +0100 From: Mark Brown To: Douglas Anderson Cc: lgirdwood@gmail.com, mka@chromium.org, briannorris@chromium.org, javier@dowhile0.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Message-ID: <20160901195106.GM5967@sirena.org.uk> References: <1472617277-30814-1-git-send-email-dianders@chromium.org> <1472617277-30814-2-git-send-email-dianders@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WuedheRyq6FDfQ9j" Content-Disposition: inline In-Reply-To: <1472617277-30814-2-git-send-email-dianders@chromium.org> X-Cookie: Beware of computerized fortune-tellers! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3 2/2] regulator: pwm: Prevent falling too fast X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --WuedheRyq6FDfQ9j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 30, 2016 at 09:21:16PM -0700, Douglas Anderson wrote: > In this patch we actually block returning from the set_voltage() call > until we've finished delaying. A future patch atop this one might > choose to return more immediately and let the voltages fall in the > background. That would possibly to allow us to cancel a slow downward > decay if there was a request to go back up. We already have mechanisms in the core for drivers to tell the core how long a ramp they need for a given voltage transition - you should extend them (probably needs a set_voltage_time() operation adding) so that anything like this can be done in the core rather than open coded in drivers. --WuedheRyq6FDfQ9j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXyIapAAoJECTWi3JdVIfQH/sH/019NSsj2ZkhigUIIiffZnKR ZuP/Oi0cmEQcG87Pyn7ENVPDdvbiKzq2kx72tVNKjNBSFnNKHL1e8ZVWO0hGi7xp YUxL+KhFFC5pKSHppjvsfY3UxawTaC3IBRX9eVBHfysLtaQmPhouk6pKyXuiqL99 nbB/ktvjR4EVGNh8PFCINlzvJPUvfj7/mVz+v/dx1MYql0lwU0+1e0AO27lkCjCi FbOtt5GSWp1EyIkbD+jCmeeqwhVgHp9IRCG/oe92GFJ8zlJu2dRLCd6e04pPcocf 66/kdGXqC5VTkdnDYA8JqjU/zm1hPmXkS39g1IZssqbjnx2QxP7IyKyT26R7LNc= =Xidr -----END PGP SIGNATURE----- --WuedheRyq6FDfQ9j--