mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Louie Lu <louie.lu@hopebaytech.com>
Cc: linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net,
	Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
	Amitoj Kaur Chawla <amitoj1606@gmail.com>,
	Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
	punit vara <punitvara@gmail.com>,
	Parth Sane <laerdevstudios@gmail.com>,
	Shivani Bhardwaj <shivanib134@gmail.com>,
	devel@driverdev.osuosl.org
Subject: Re: [PATCH 3/3] staging: rtl8712: fixed comment style and space indent
Date: Fri, 2 Sep 2016 15:07:36 +0200	[thread overview]
Message-ID: <20160902130736.GA2833@kroah.com> (raw)
In-Reply-To: <CAEQ0BR6AczvyGJZ=QTQN_18qY=kqS-WM09VHTPDXT+=+wMjMGw@mail.gmail.com>

On Fri, Sep 02, 2016 at 09:04:29PM +0800, Louie Lu wrote:
> 2016-09-02 20:55 GMT+08:00 Greg KH <gregkh@linuxfoundation.org>:
> > On Fri, Sep 02, 2016 at 06:16:10PM +0800, Louie Lu wrote:
> >> fixed comment style and space indent report from checkpatch:
> >>
> >> * WARNING: Statements should start on a tabstop
> >> * WARNING: Block comments use * on subsequent lines
> >> * WARNING: suspect code indent for conditional statements (16, 32)
> >>
> >> Signed-off-by: Louie Lu <louie.lu@hopebaytech.com>
> >> ---
> >>  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 37 ++++++++++++++++-----------
> >>  1 file changed, 22 insertions(+), 15 deletions(-)
> >
> > This patch adds errors :(
> >
> > Now if you want to constantly submit new checkpatch cleanups to the
> > driver, that's a good thing, but really, please use checkpatch on your
> > patches to ensure you are doing things properly.
> >
> > I'm dropping it from my patch queue.
> >
> > thanks,
> >
> > greg k-h
> 
> Hi Greg,
> 
> sorry about that I didn't know I add error to this file.
> I'll make sure this won't happen again.
> 
> And if I want to resubmit this patch 3/3, I'll only need to resend this one,
> like [PATCH 3/3 v2] this way?

I've already taken the first 2 so just send it as a single patch.

thanks,

greg k-h

      reply	other threads:[~2016-09-02 13:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1472810639.git.louie.lu@hopebaytech.com>
2016-09-02 10:15 ` [PATCH 1/3] staging: rtl8712: delete one space before if statement Louie Lu
2016-09-02 10:15 ` [PATCH 2/3] staging: rtl8172: fixed comment style in rts871x_cmd.c Louie Lu
2016-09-02 10:16 ` [PATCH 3/3] staging: rtl8712: fixed comment style and space indent Louie Lu
2016-09-02 12:55   ` Greg KH
2016-09-02 13:04     ` Louie Lu
2016-09-02 13:07       ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160902130736.GA2833@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=amitoj1606@gmail.com \
    --cc=bhaktipriya96@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=laerdevstudios@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louie.lu@hopebaytech.com \
    --cc=punitvara@gmail.com \
    --cc=shivanib134@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®