From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752359AbcIBN2U (ORCPT ); Fri, 2 Sep 2016 09:28:20 -0400 Received: from outbound1.eu.mailhop.org ([52.28.251.132]:38932 "EHLO outbound1.eu.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbcIBN2R (ORCPT ); Fri, 2 Sep 2016 09:28:17 -0400 X-MHO-User: 1a33dec5-7111-11e6-b159-2d56437e1029 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 173.50.81.193 X-Mail-Handler: DuoCircle Outbound SMTP X-DKIM: OpenDKIM Filter v2.6.8 io 990268008C Date: Fri, 2 Sep 2016 13:28:06 +0000 From: Jason Cooper To: Michal Simek Cc: Zubair Lutfullah Kakakhel , monstr@monstr.eu, ralf@linux-mips.org, tglx@linutronix.de, marc.zyngier@arm.com, soren.brinkmann@xilinx.com, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, netdev@vger.kernel.org Subject: Re: [Patch v4 01/12] microblaze: irqchip: Move intc driver to irqchip Message-ID: <20160902132806.GK10637@io.lakedaemon.net> References: <1472748665-47774-1-git-send-email-Zubair.Kakakhel@imgtec.com> <1472748665-47774-2-git-send-email-Zubair.Kakakhel@imgtec.com> <772f883f-79fe-9197-f27c-3ffe91019aaf@xilinx.com> <5d98fd3b-4722-cdd3-4540-c1d1fec1c98c@imgtec.com> <4931182d-7b30-582f-f291-5be59b6b89e4@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4931182d-7b30-582f-f291-5be59b6b89e4@xilinx.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal, Zubair, On Fri, Sep 02, 2016 at 12:27:54PM +0200, Michal Simek wrote: > On 2.9.2016 12:06, Zubair Lutfullah Kakakhel wrote: > > On 09/02/2016 07:25 AM, Michal Simek wrote: ... > >> Also there is another copy of this driver in the tree which was using > >> old ppc405 and ppc440 xilinx platforms. > >> > >> arch/powerpc/include/asm/xilinx_intc.h > >> arch/powerpc/sysdev/xilinx_intc.c > >> > >> These should be also removed by moving this driver to generic folder. > > > > I didn't know about that drivers existence. > > > > This patch series already touches microblaze, mips and irqchip. > > Both microblaze and mips platforms using this driver are little-endian. > > MB is big ending too and as you see there is big endian support in the > driver already. > > > > > Adding a big-endian powerpc driver + platform to the mix is going to > > complicate the series further and make it super hard to synchronize > > various subsystems, test stuff, and then move the drivers without > > breakage. The whole point of Linus' push to move drivers out of arch/ is to reduce code duplication and create more robust drivers. > > I'd highly recommend letting this move happen. And then the powerpc > > driver can transition over time to this driver. I've seen this argument before, and despite everyone's best intentions, it never happens. :( We have linux-next, 0-day and other resources to test these sorts of changes and catch errors before they hit mainline. Let's take our time and do it right. thx, Jason.