From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754635AbcIDUbF (ORCPT ); Sun, 4 Sep 2016 16:31:05 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:38678 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754415AbcIDUbC (ORCPT ); Sun, 4 Sep 2016 16:31:02 -0400 Date: Sun, 04 Sep 2016 13:28:54 -0700 (PDT) Message-Id: <20160904.132854.1438256363591084718.davem@davemloft.net> To: joe@perches.com Cc: Yuval.Mintz@qlogic.com, Ariel.Elior@qlogic.com, everest-linux-l2@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qed: Remove OOM messages From: David Miller In-Reply-To: <6d6f56d8324237957b19f069357e2aa9e4bcd959.1472836194.git.joe@perches.com> References: <1472838261.6758.74.camel@perches.com> <6d6f56d8324237957b19f069357e2aa9e4bcd959.1472836194.git.joe@perches.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 04 Sep 2016 13:28:56 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Perches Date: Fri, 2 Sep 2016 10:48:47 -0700 > These messages are unnecessary as OOM allocation failures already do > a dump_stack() giving more or less the same information. > > $ size drivers/net/ethernet/qlogic/qed/built-in.o* (defconfig x86-64) > text data bss dec hex filename > 126849 27968 32800 187617 2dce1 drivers/net/ethernet/qlogic/qed/built-in.o.new > 131506 27968 32800 192274 2ef12 drivers/net/ethernet/qlogic/qed/built-in.o.old > > Miscellanea: > > o Change allocs to the generally preferred forms where possible. > > Signed-off-by: Joe Perches Joe can you respin this against net-next? It applies against 'net' but this isn't really a critical bug fix and it'll also create conflicts against net-next. Thanks.