From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753901AbcIDPlN (ORCPT ); Sun, 4 Sep 2016 11:41:13 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:36150 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752962AbcIDPlM (ORCPT ); Sun, 4 Sep 2016 11:41:12 -0400 Date: Sun, 4 Sep 2016 21:11:01 +0530 From: Sudip Mukherjee To: Baoyou Xie Cc: gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org, arnd@arndb.de Subject: Re: [PATCH] staging/android: mark sync_timeline_create() static Message-ID: <20160904154101.GD29779@sudip-laptop> References: <1472884453-19941-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472884453-19941-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 03, 2016 at 02:34:13PM +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/staging/android/sw_sync.c:56:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > so this patch marks this function with 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/staging/android/sw_sync.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) which tree are you using? This file has been removed from staging by: 35538d7822e8 ("dma-buf/sw_sync: de-stage SW_SYNC") regards sudip