From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754634AbcIDT2x (ORCPT ); Sun, 4 Sep 2016 15:28:53 -0400 Received: from libra.uberspace.de ([95.143.172.171]:50708 "EHLO libra.uberspace.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754401AbcIDT2w (ORCPT ); Sun, 4 Sep 2016 15:28:52 -0400 From: Matthias Beyer To: gregkh@linuxfoundation.org Cc: Matthias Beyer , Larry Finger , Jes Sorensen , Manuel Messner , Geliang Tang , Cihangir Akturk , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] drivers: staging: rtl8723au: core: Refactor pointless branching Date: Sun, 4 Sep 2016 21:26:24 +0200 Message-Id: <20160904192626.17197-4-mail@beyermatthias.de> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20160904192626.17197-1-mail@beyermatthias.de> References: <20160904192626.17197-1-mail@beyermatthias.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As ether_addr_equal returns a bool, we can simply use the return value to set the variable. Signed-off-by: Matthias Beyer Signed-off-by: Manuel Messner --- drivers/staging/rtl8723au/core/rtw_mlme.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c index da9f298..196447b 100644 --- a/drivers/staging/rtl8723au/core/rtw_mlme.c +++ b/drivers/staging/rtl8723au/core/rtw_mlme.c @@ -1062,11 +1062,8 @@ void rtw_joinbss_event_prehandle23a(struct rtw_adapter *adapter, u8 *pbuf) pmlmepriv->assoc_ssid.ssid); } - if (ether_addr_equal(pnetwork->network.MacAddress, - cur_network->network.MacAddress)) - the_same_macaddr = true; - else - the_same_macaddr = false; + the_same_macaddr = ether_addr_equal(pnetwork->network.MacAddress, + cur_network->network.MacAddress); pnetwork->network.Length = get_wlan_bssid_ex_sz(&pnetwork->network); if (pnetwork->network.Length > sizeof(struct wlan_bssid_ex)) { -- 2.9.3