From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933315AbcIEKiH (ORCPT ); Mon, 5 Sep 2016 06:38:07 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:12435 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932249AbcIEKiE (ORCPT ); Mon, 5 Sep 2016 06:38:04 -0400 X-IronPort-AV: E=Sophos;i="5.30,286,1470693600"; d="scan'208";a="192084678" Date: Mon, 5 Sep 2016 12:38:01 +0200 From: Samuel Thibault To: Pavel Andrianov Cc: William Hubbs , Chris Brannon , Kirk Reiser , speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Vaishali Thakkar , ldv-project@linuxtesting.org Subject: Re: A potential race in drivers/staging/speakup/speakup.ko Message-ID: <20160905103801.GN15376@var.bordeaux.inria.fr> Mail-Followup-To: Samuel Thibault , Pavel Andrianov , William Hubbs , Chris Brannon , Kirk Reiser , speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Vaishali Thakkar , ldv-project@linuxtesting.org References: <2b13ceb6-9494-7bec-d0e5-8033c66a8721@ispras.ru> <20160905094317.GB15376@var.bordeaux.inria.fr> <58cca2ca-e73c-b7ae-9da9-36be6084caf4@ispras.ru> <20160905095638.GL15376@var.bordeaux.inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pavel Andrianov, on Mon 05 Sep 2016 13:33:33 +0300, wrote: > synth_direct_store may be called via device_attributes interface. Ah, right. > In which function the lock should be added? That'd be synth_direct_store then, around the while loop. Samuel