From: Peter Zijlstra <peterz@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Waiman Long <waiman.long@hpe.com>, Jason Low <jason.low2@hpe.com>,
Ding Tianhong <dingtianhong@huawei.com>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <Will.Deacon@arm.com>, Ingo Molnar <mingo@redhat.com>,
Imre Deak <imre.deak@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Tim Chen <tim.c.chen@linux.intel.com>,
Terry Rudd <terry.rudd@hpe.com>,
"Paul E. McKenney" <paulmck@us.ibm.com>,
Jason Low <jason.low2@hp.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Fengguang Wu <fengguang.wu@intel.com>
Subject: [PATCH -v3 02/10] sh/atomic: Fix ATOMIC_FETCH_OP()
Date: Mon, 05 Sep 2016 14:36:38 +0200 [thread overview]
Message-ID: <20160905124027.306155176@infradead.org> (raw)
In-Reply-To: <20160905123636.450529224@infradead.org>
[-- Attachment #1: peterz-atomic-fix-sh.patch --]
[-- Type: text/plain, Size: 815 bytes --]
We cannot use the "z" constraint twice, since its a single register
(r0). Change the one not used by movli.l/movco.l to "r".
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Tested-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
arch/sh/include/asm/atomic-llsc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/sh/include/asm/atomic-llsc.h
+++ b/arch/sh/include/asm/atomic-llsc.h
@@ -60,7 +60,7 @@ static inline int atomic_fetch_##op(int
" movco.l %0, @%3 \n" \
" bf 1b \n" \
" synco \n" \
- : "=&z" (temp), "=&z" (res) \
+ : "=&z" (temp), "=&r" (res) \
: "r" (i), "r" (&v->counter) \
: "t"); \
\
next prev parent reply other threads:[~2016-09-05 12:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 12:36 [PATCH -v3 00/10] locking/mutex: Rewrite basic mutex Peter Zijlstra
2016-09-05 12:36 ` [PATCH -v3 01/10] locking/drm: Kill mutex trickery Peter Zijlstra
2016-09-05 12:36 ` Peter Zijlstra [this message]
2016-09-05 12:36 ` [PATCH -v3 03/10] locking/mutex: Rework mutex::owner Peter Zijlstra
2016-09-05 12:36 ` [PATCH -v3 04/10] locking/mutex: Kill arch specific code Peter Zijlstra
2016-09-05 12:36 ` [PATCH -v3 05/10] locking/mutex: Allow MUTEX_SPIN_ON_OWNER when DEBUG_MUTEXES Peter Zijlstra
2016-09-05 12:36 ` [PATCH -v3 06/10] locking/mutex: Add lock handoff to avoid starvation Peter Zijlstra
2016-09-05 12:36 ` [PATCH -v3 07/10] mutex: Restructure wait loop Peter Zijlstra
[not found] ` <57D31A3B.7000105@hpe.com>
[not found] ` <57D31C67.8010809@hpe.com>
2016-09-14 10:33 ` Peter Zijlstra
2016-09-05 12:36 ` [PATCH -v3 08/10] locking/mutex: Simplify some ww_mutex code in __mutex_lock_common() Peter Zijlstra
2016-09-05 12:36 ` [PATCH -v3 09/10] locking/mutex: Enable optimistic spinning of woken waiter Peter Zijlstra
2016-09-05 12:36 ` [RFC][PATCH -v3 10/10] locking/mutex: Implement alternative HANDOFF Peter Zijlstra
2016-09-09 22:32 ` Waiman Long
2016-09-12 15:20 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905124027.306155176@infradead.org \
--to=peterz@infradead.org \
--cc=Will.Deacon@arm.com \
--cc=dalias@libc.org \
--cc=dave@stgolabs.net \
--cc=dingtianhong@huawei.com \
--cc=fengguang.wu@intel.com \
--cc=imre.deak@intel.com \
--cc=jason.low2@hp.com \
--cc=jason.low2@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@us.ibm.com \
--cc=terry.rudd@hpe.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=waiman.long@hpe.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome