From: Greg KH <gregkh@linuxfoundation.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: David Hsu <davidhsu@google.com>,
sspatil@google.com, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm: Unexport children before chip removal
Date: Mon, 5 Sep 2016 17:03:51 +0200 [thread overview]
Message-ID: <20160905150351.GB10308@kroah.com> (raw)
In-Reply-To: <20160905144641.GR31424@ulmo.ba.sec>
On Mon, Sep 05, 2016 at 04:46:41PM +0200, Thierry Reding wrote:
> On Tue, Aug 09, 2016 at 02:57:46PM -0700, David Hsu wrote:
> > Exported pwm channels aren't removed before the pwmchip and are
> > leaked. This results in invalid sysfs files. This fix removes
> > all exported pwm channels before chip removal.
> >
> > Signed-off-by: David Hsu <davidhsu@google.com>
> > ---
> > drivers/pwm/core.c | 2 ++
> > drivers/pwm/sysfs.c | 18 ++++++++++++++++++
> > include/linux/pwm.h | 5 +++++
> > 3 files changed, 25 insertions(+)
>
> I've applied this with the following added to the commit message:
>
> Fixes: 76abbdde2d95 ("pwm: Add sysfs interface")
>
> since this seems to have been wrong since forever.
Wonderful, thanks for doing that.
greg k-h
prev parent reply other threads:[~2016-09-05 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 21:57 David Hsu
[not found] ` <20160810084957.GC12080@kroah.com>
2016-08-10 22:54 ` David Hsu
2016-09-05 14:46 ` Thierry Reding
2016-09-05 15:03 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905150351.GB10308@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davidhsu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=sspatil@google.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®