From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965796AbcIERBf (ORCPT ); Mon, 5 Sep 2016 13:01:35 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:36058 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965514AbcIERB3 (ORCPT ); Mon, 5 Sep 2016 13:01:29 -0400 From: Colin King To: "David S . Miller" , David Howells , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] rxrpc: initialize sched to false to ensure it is not a garbage value Date: Mon, 5 Sep 2016 18:00:02 +0100 Message-Id: <20160905170002.18792-1-colin.king@canonical.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King sched will be uninitialized (and contain a garbage value) in the case where call->state >= RXRPC_CALL_DEAD; fix this by initializing sched to false to avoid an inadvertent call to rxrpc_queue_call. Signed-off-by: Colin Ian King --- net/rxrpc/call_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/call_object.c b/net/rxrpc/call_object.c index 516d8ea..57e00fc 100644 --- a/net/rxrpc/call_object.c +++ b/net/rxrpc/call_object.c @@ -586,7 +586,7 @@ static void rxrpc_dead_call_expired(unsigned long _call) */ static void rxrpc_mark_call_released(struct rxrpc_call *call) { - bool sched; + bool sched = false; rxrpc_see_call(call); write_lock(&call->state_lock); -- 2.9.3