mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrey Utkin <andrey_utkin@fastmail.com>
To: Fernando Apesteguia <fernando.apesteguia@gmail.com>
Cc: lidza.louina@gmail.com, gregkh@linuxfoundation.org,
	driverdev-devel@linuxdriverproject.org,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: dgnc: Fix multi line comment alignment
Date: Mon, 5 Sep 2016 23:45:30 +0300	[thread overview]
Message-ID: <20160905204530.vdodbxpqvo5wrvj7@zver> (raw)
In-Reply-To: <20160905182832.GA10312@erazer>

On Mon, Sep 05, 2016 at 08:28:32PM +0200, Fernando Apesteguia wrote:
> Fix alignment in multi line comment block.
> 
> Remove extra '*' to use the preferred comment style as in Documentation/CodingStyle
> 
> Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com>
> 
> ---
>  drivers/staging/dgnc/dgnc_driver.c | 50 +++++++++++++++++++-------------------
>  1 file changed, 25 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> index cc6105a..01e948c 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -602,31 +602,31 @@ static void dgnc_do_remap(struct dgnc_board *brd)
>  	brd->re_map_membase = ioremap(brd->membase, 0x1000);
>  }
>  
> -/*****************************************************************************
> -*
> -* Function:
> -*
> -*    dgnc_poll_handler
> -*
> -* Author:
> -*
> -*    Scott H Kilau
> -*
> -* Parameters:
> -*
> -*    dummy -- ignored
> -*
> -* Return Values:
> -*
> -*    none
> -*
> -* Description:
> -*
> -*    As each timer expires, it determines (a) whether the "transmit"
> -*    waiter needs to be woken up, and (b) whether the poller needs to
> -*    be rescheduled.
> -*
> -******************************************************************************/
> +/*
> + *
> + * Function:
> + *
> + *    dgnc_poll_handler
> + *
> + * Author:
> + *
> + *    Scott H Kilau
> + *
> + * Parameters:
> + *
> + *    dummy -- ignored
> + *
> + * Return Values:
> + *
> + *    none
> + *
> + * Description:
> + *
> + *    As each timer expires, it determines (a) whether the "transmit"
> + *    waiter needs to be woken up, and (b) whether the poller needs to
> + *    be rescheduled.
> + *
> + */
>  
>  static void dgnc_poll_handler(ulong dummy)
>  {
> -- 
> 2.7.4

Changing first and last lines of that comment should be enough, but all
lines got changed. I'd (re)submit it with just first and last lines
changed.

  reply	other threads:[~2016-09-05 20:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05 18:28 Fernando Apesteguia
2016-09-05 20:45 ` Andrey Utkin [this message]
2016-09-06 13:19   ` Fernando Apesteguia
2016-09-06 14:49     ` Andrey Utkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160905204530.vdodbxpqvo5wrvj7@zver \
    --to=andrey_utkin@fastmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=fernando.apesteguia@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=lidza.louina@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®