From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964883AbcIFUyq (ORCPT ); Tue, 6 Sep 2016 16:54:46 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:53914 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935767AbcIFUyn (ORCPT ); Tue, 6 Sep 2016 16:54:43 -0400 Date: Tue, 06 Sep 2016 13:54:42 -0700 (PDT) Message-Id: <20160906.135442.1020937848957246873.davem@davemloft.net> To: joe@perches.com Cc: Yuval.Mintz@qlogic.com, Ariel.Elior@qlogic.com, everest-linux-l2@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH V2] qed: Remove OOM messages From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 06 Sep 2016 13:54:42 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Perches Date: Sun, 4 Sep 2016 14:24:03 -0700 > These messages are unnecessary as OOM allocation failures already do > a dump_stack() giving more or less the same information. > > $ size drivers/net/ethernet/qlogic/qed/built-in.o* (defconfig x86-64) > text data bss dec hex filename > 127817 27969 32800 188586 2e0aa drivers/net/ethernet/qlogic/qed/built-in.o.new > 132474 27969 32800 193243 2f2db drivers/net/ethernet/qlogic/qed/built-in.o.old > > Miscellanea: > > o Change allocs to the generally preferred forms where possible. > > Signed-off-by: Joe Perches Applied.