From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935948AbcIFW6E (ORCPT ); Tue, 6 Sep 2016 18:58:04 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:55888 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932753AbcIFW6B (ORCPT ); Tue, 6 Sep 2016 18:58:01 -0400 Date: Tue, 06 Sep 2016 15:57:57 -0700 (PDT) Message-Id: <20160906.155757.924163804989771884.davem@davemloft.net> To: hejianet@gmail.com Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, vyasevich@gmail.com, nhorman@tuxdriver.com, steffen.klassert@secunet.com, herbert@gondor.apana.org.au Subject: Re: [RFC PATCH v2 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show From: David Miller In-Reply-To: <1473129009-20478-2-git-send-email-hejianet@gmail.com> References: <1473129009-20478-1-git-send-email-hejianet@gmail.com> <1473129009-20478-2-git-send-email-hejianet@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 06 Sep 2016 15:58:00 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia He Date: Tue, 6 Sep 2016 10:30:04 +0800 > +#define MAX(a, b) ((u32)(a) >= (u32)(b) ? (a) : (b)) Please do not define private min/max macros, use the existing max_t() or similar as needed.