From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755697AbcIFMBA (ORCPT ); Tue, 6 Sep 2016 08:01:00 -0400 Received: from tex.lwn.net ([70.33.254.29]:57369 "EHLO vena.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753827AbcIFMA6 (ORCPT ); Tue, 6 Sep 2016 08:00:58 -0400 Date: Tue, 6 Sep 2016 06:00:50 -0600 From: Jonathan Corbet To: Arnd Bergmann Cc: Laura Abbott , Randy Dunlap , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] doc: ioctl: Add some clarifications to botching-up-ioctls Message-ID: <20160906060050.0518d31a@lwn.net> In-Reply-To: <14410979.OgeTP9zliP@wuerfel> References: <1472856144-4659-1-git-send-email-labbott@redhat.com> <14410979.OgeTP9zliP@wuerfel> Organization: LWN.net X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 03 Sep 2016 00:44:02 +0200 Arnd Bergmann wrote: > On Friday, September 2, 2016 3:42:24 PM CEST Laura Abbott wrote: > > - The guide currently says to pad the structure to a multiple of > > 64-bits. This is not necessary in cases where the structure contains > > no 64-bit types. Clarify this concept to avoid unnecessary padding. > > - When using __u64 to hold user pointers, blindly trying to do a cast to > > a void __user * may generate a warning on 32-bit systems about a cast > > from an integer to a pointer of different size. There is a macro to > > deal with this which hides an ugly double cast. Add a reference to > > this macro. > > > > Signed-off-by: Laura Abbott > > > > Looks good to me, > > Acked-by: Arnd Bergmann Applied to the docs tree, thanks. jon