From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935362AbcIGAab (ORCPT ); Tue, 6 Sep 2016 20:30:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:48571 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935221AbcIGAa1 (ORCPT ); Tue, 6 Sep 2016 20:30:27 -0400 Date: Wed, 7 Sep 2016 02:30:23 +0200 From: "Luis R. Rodriguez" To: Daniel Wagner Cc: "Luis R. Rodriguez" , Daniel Wagner , linux-kernel@vger.kernel.org, Ming Lei , Greg Kroah-Hartman Subject: Re: [PATCH v3 1/3] firmware_class: encapsulate firmware loading status Message-ID: <20160907003023.GW3296@wotan.suse.de> References: <1472118723-22762-1-git-send-email-wagi@monom.org> <1472118723-22762-2-git-send-email-wagi@monom.org> <20160825175007.GA3296@wotan.suse.de> <151b26a2-6562-b37b-43e2-9040f0609a1c@bmw-carit.de> <1ffedc17-d2e8-7843-d1e5-5da20d4cae91@bmw-carit.de> <20160830193446.GU3296@wotan.suse.de> <6c589f0a-6503-6104-c10c-80ebd6884995@monom.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6c589f0a-6503-6104-c10c-80ebd6884995@monom.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2016 at 09:13:45AM +0200, Daniel Wagner wrote: > Hi Luis, > > On 08/30/2016 09:34 PM, Luis R. Rodriguez wrote: > >On Mon, Aug 29, 2016 at 04:18:33PM +0200, Daniel Wagner wrote: > >>On 08/29/2016 11:50 AM, Daniel Wagner wrote: > >>I forgot to answer your question. So we have the dependency to > >>loading_timeout/firmware_loading_timeout from the firmware caching > >>path. The patch added in the previous email removes that dependency. > >> > >>We still need the 60 second even in the > >>!CONFIG_FW_LOADER_USER_HELPER case. I think it would be a regression > >>if we change that value, no? > > > >Oh that might be the disconnect, see my series of pending patches, I did away > >with the cache stuff using the usermode helper, the cache stuff should not use > >the usermode helper as the cache stuff kills off the pending usermode helper > >requests right before suspend. > > The question is how do we proceed from here. I suggest that I don't > touch the fw cache path in my patches. Basically, leave it as it > now. After your series in, we cleanup this bit here, maybe even move > the user helper stuff into its own file. > > I think this code is a big interleaved puzzle. Best thing is to > split it up and figure out what interacts with what. Moving this > bits here out is definitely the right direction. How about I remove the timeout crap form the cache stuff in my patch as you noted and fold then your changes on top of that pending series? Luis