From: Johannes Thumshirn <jthumshirn@suse.de>
To: Long Li <longli@exchange.microsoft.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
devel@linuxdriverproject.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, Long Li <longli@microsoft.com>
Subject: Re: [PATCH 1/3] storvsc: use tagged SRB requests if supported by the device
Date: Wed, 7 Sep 2016 09:46:45 +0200 [thread overview]
Message-ID: <20160907074645.6ecwmq7pmf6mb4pg@c203.arch.suse.de> (raw)
In-Reply-To: <1473197143-16760-2-git-send-email-longli@exchange.microsoft.com>
On Tue, Sep 06, 2016 at 02:25:41PM -0700, Long Li wrote:
> From: Long Li <longli@microsoft.com>
>
> Properly set SRB flags when hosting device supports tagged queuing. This patch improves the performance on Fiber Channel disks.
ENOSIGNEDOFF and please use checkpatch.pl on the patch.
>
> ---
> drivers/scsi/storvsc_drv.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 8ccfc9e..a8f3e4c 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -136,6 +136,8 @@ struct hv_fc_wwn_packet {
> #define SRB_FLAGS_PORT_DRIVER_RESERVED 0x0F000000
> #define SRB_FLAGS_CLASS_DRIVER_RESERVED 0xF0000000
>
> +#define SP_UNTAGGED ((unsigned char) ~0)
> +#define SRB_SIMPLE_TAG_REQUEST 0x20
>
> /*
> * Platform neutral description of a scsi request -
> @@ -1451,6 +1453,12 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
> vm_srb->win8_extension.srb_flags |=
> SRB_FLAGS_DISABLE_SYNCH_TRANSFER;
>
> + if(scmnd->device->tagged_supported) {
> + vm_srb->win8_extension.srb_flags |= (SRB_FLAGS_QUEUE_ACTION_ENABLE | SRB_FLAGS_NO_QUEUE_FREEZE);
> + vm_srb->win8_extension.queue_tag = SP_UNTAGGED;
> + vm_srb->win8_extension.queue_action = SRB_SIMPLE_TAG_REQUEST;
> + }
> +
> /* Build the SRB */
> switch (scmnd->sc_data_direction) {
> case DMA_TO_DEVICE:
> --
> 1.8.5.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2016-09-07 7:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 21:25 [PATCH 0/3] storvsc: fixes issues on Fiber Channel Long Li
2016-09-06 21:25 ` [PATCH 1/3] storvsc: use tagged SRB requests if supported by the device Long Li
2016-09-07 7:46 ` Johannes Thumshirn [this message]
2016-09-07 17:19 ` Long Li
2016-09-06 21:25 ` [PATCH 2/3] storvsc: properly handle SRB_ERROR when sense message is present Long Li
2016-09-06 21:25 ` [PATCH 3/3] storvsc: use block layer default segment size Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907074645.6ecwmq7pmf6mb4pg@c203.arch.suse.de \
--to=jthumshirn@suse.de \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=longli@exchange.microsoft.com \
--cc=longli@microsoft.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®