From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756843AbcIGT5H (ORCPT <rfc822;w@1wt.eu>);
        Wed, 7 Sep 2016 15:57:07 -0400
Received: from muru.com ([72.249.23.125]:41559 "EHLO muru.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1756339AbcIGT4O (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 7 Sep 2016 15:56:14 -0400
Date: Wed, 7 Sep 2016 12:56:10 -0700
From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Vinod Koul <vinod.koul@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Lars-Peter Clausen <lars@metafoo.de>, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: cppi41: mark PM functions as __maybe_unused
Message-ID: <20160907195610.4em7ykm3m7sb6ldh@atomide.com>
References: <20160906132030.2014181-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160906132030.2014181-1-arnd@arndb.de>
User-Agent: Mutt/1.6.2-neo (2016-07-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Arnd Bergmann <arnd@arndb.de> [160906 06:20]:
> When CONFIG_PM_SLEEP is disabled, we get a build error in
> the cppi41 dmaengine driver, since the runtime-pm functions
> are hidden within the wrong #ifdef:
> 
> drivers/dma/cppi41.c:1158:21: error: 'cppi41_runtime_suspend' undeclared here (not in a function)
> 
> This removes the #ifdef and instead uses __maybe_unused
> annotations that cannot have this problem.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support")

Thanks for fixing it:

Acked-by: Tony Lindgren <tony@atomide.com>