From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754190AbcIHC2I (ORCPT ); Wed, 7 Sep 2016 22:28:08 -0400 Received: from mail-lf0-f48.google.com ([209.85.215.48]:35775 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751529AbcIHC17 (ORCPT ); Wed, 7 Sep 2016 22:27:59 -0400 Date: Thu, 8 Sep 2016 05:27:55 +0300 From: Andrey Utkin To: Julia Lawall Cc: Mauro Carvalho Chehab , kernel-janitors@vger.kernel.org, Ezequiel Garcia , Hans Verkuil , Ismael Luceno , Bluecherry Maintainers , Andy Walls , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [media] pci: constify snd_pcm_ops structures Message-ID: <20160908022755.mr45eulz4r7vfoo5@zver> References: <1473295479-24615-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473295479-24615-1-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.6.2 (2016-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for looking into this. I have tested that it compiles and passes checks (C=2) cleanly after this patch. Acked-by: Andrey Utkin While we're at it, what about constification of *-core.c:static struct pci_driver *_pci_driver = { *-video.c:static struct vb2_ops *_video_qops = { *-video.c:static struct video_device *_video_template = { in drivers/media/pci/? Also there are even more similar entries not constified yet in drivers/media/, however I may be underestimating complexity of making semantic rules for catching that all.