From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758441AbcIHIjy (ORCPT ); Thu, 8 Sep 2016 04:39:54 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:42651 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753307AbcIHIjw (ORCPT ); Thu, 8 Sep 2016 04:39:52 -0400 From: Colin King To: Mauro Carvalho Chehab , Doug Thompson , Borislav Petkov , linux-edac@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] EDAC: sb_edac: remove null pointer check on array pci_tad Date: Thu, 8 Sep 2016 09:38:01 +0100 Message-Id: <20160908083801.14766-1-colin.king@canonical.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King pvt->pci_tad is a NUM_CHANNELS array of struct pci_dev pointers and hence cannot be null, so the pull pointer check on pci_tad is redundant. Remove it. Signed-off-by: Colin Ian King --- drivers/edac/sb_edac.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c index ce0067b..5477522 100644 --- a/drivers/edac/sb_edac.c +++ b/drivers/edac/sb_edac.c @@ -2474,7 +2474,7 @@ static int sbridge_mci_bind_devs(struct mem_ctl_info *mci, /* Check if everything were registered */ if (!pvt->pci_sad0 || !pvt->pci_sad1 || !pvt->pci_ha0 || - !pvt-> pci_tad || !pvt->pci_ras || !pvt->pci_ta) + !pvt->pci_ras || !pvt->pci_ta) goto enodev; if (saw_chan_mask != 0x0f) @@ -2563,8 +2563,7 @@ static int ibridge_mci_bind_devs(struct mem_ctl_info *mci, /* Check if everything were registered */ if (!pvt->pci_sad0 || !pvt->pci_ha0 || !pvt->pci_br0 || - !pvt->pci_br1 || !pvt->pci_tad || !pvt->pci_ras || - !pvt->pci_ta) + !pvt->pci_br1 || !pvt->pci_ras || !pvt->pci_ta) goto enodev; if (saw_chan_mask != 0x0f && /* -EN */ -- 2.9.3