From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757003AbcIHNyC (ORCPT ); Thu, 8 Sep 2016 09:54:02 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:61920 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751944AbcIHNyA (ORCPT ); Thu, 8 Sep 2016 09:54:00 -0400 From: Arnd Bergmann To: Dan Williams Cc: Arnd Bergmann , Johannes Thumshirn , linux-kernel@vger.kernel.org Subject: [PATCH] dax: use correct dev_t value Date: Thu, 8 Sep 2016 15:53:28 +0200 Message-Id: <20160908135431.1310985-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:UBKTLuEMBG4l/urXl9YgRtjEDP9KD9oyv5Wa6KKncpetgum3tM7 GvCKo4VEvVOqT+Iq88bAoxuZf2HhrXFsEuS2SK6LVahiwkhY8xg+aNyN8MDjF8BM1ZHyL6P fbwKZiwnw+OQYxL3Xo9ixJAH1ig08PpHU26GtRqcKGEXCHfid+h0Pct4czqeAQaAZG0IyX5 hsiNBmoWdxGhfuzZrNi4w== X-UI-Out-Filterresults: notjunk:1;V01:K0:Q4Bju8kEADE=:A4G3nG3TMgp6fTiqUvKxIN jh/zRiLy99f/fU5R2BNyGwpSaiCqE/4sOYJVNviJT/iwgWn8tOeDoYqSVPF+icRyJUEUJY/KV 9xH/tkXD2BpeKBrcyW8MWzzncocT8X7Ip4sjMvrmpFtXD8jQd8RGZYBl/zAudy8HgiS9fSOOz GFATt4yFxMQ0bp5FYEMOK/OOcY3tIRG/GdYb1BJ2xcQWk5MQvpBZISdNofImJ9E0/xi6pOyR1 9WN727EmCWj+dEm7HX7QBV8+pAHQD8sdm4PVqoeFeeb+DtOs7Ws3MOWUC6tfUHN4Ru+mjpGJi uIlUUiD/aLhP9/ftktdrdSnxD5q1EybztjmEbO2Ec75kU3/7RniCdg7s7jTaPPm6tOx/2zbgo vAP3TJh/OA6VidVinbc0kW9Q0S4zXceXykxB/kZu7t4u6iEy0LN2kSn9k1/MonkRRR4NYkn2C EEYiGTihfR+VcxjX5gC3xaC0SGEUtYUN6YACN1uNmeQYPw4QlyYPR55gxq/XkxAVDBLSIrPf0 pXJ7hWRnB30AC2Up1AnSWJCSvs6VKFlbR+CHefRNYwPb7rf7yBmY7cn7bYp8gJTBHTqsp9wnO f25sytwVcTWnXNQapy2hdCSBteRCWTIJrfVen9/ecc11TeOqcgIUiN8lzhkk9dWgk1cerVev0 MegbLMCpCNDHUtIL0flvnUBErnpXGQ6iHq5EJXdOm1wxFTQzbqdWjRj5Ugi280AozGYQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The dev_t variable in devm_create_dax_dev() is used before it's first set: drivers/dax/dax.c: In function 'devm_create_dax_dev': drivers/dax/dax.c:205:39: error: 'dev_t' may be used uninitialized in this function [-Werror=maybe-uninitialized] inode = iget5_locked(dax_superblock, hash_32(devt + DAXFS_MAGIC, 31), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/dax/dax.c:688:8: note: 'dev_t' was declared here This reorders the code to how it looks correct to me. Signed-off-by: Arnd Bergmann Fixes: 3bc52c45bac2 ("dax: define a unified inode/address_space for device-dax mappings") --- drivers/dax/dax.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c index 68bb5e35b639..98dbbc12055f 100644 --- a/drivers/dax/dax.c +++ b/drivers/dax/dax.c @@ -731,6 +731,8 @@ struct dax_dev *devm_create_dax_dev(struct dax_region *dax_region, goto err_minor; } + dev_t = MKDEV(MAJOR(dax_devt), minor); + dev = &dax_dev->dev; dax_dev->inode = dax_inode_get(&dax_dev->cdev, dev_t); if (!dax_dev->inode) { rc = -ENOMEM; @@ -738,8 +740,6 @@ struct dax_dev *devm_create_dax_dev(struct dax_region *dax_region, } /* device_initialize() so cdev can reference kobj parent */ - dev_t = MKDEV(MAJOR(dax_devt), minor); - dev = &dax_dev->dev; device_initialize(dev); cdev = &dax_dev->cdev; -- 2.9.0