From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759349AbcIHSWG (ORCPT <rfc822;w@1wt.eu>);
        Thu, 8 Sep 2016 14:22:06 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:34818 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1758488AbcIHSVs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Sep 2016 14:21:48 -0400
Date: Thu, 8 Sep 2016 20:21:43 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        rjw@rjwysocki.net, tglx@linutronix.de, mingo@redhat.com, bp@suse.de,
        x86@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2 2/8] sched: Extend scheduler's asym packing
Message-ID: <20160908182143.GZ10153@twins.programming.kicks-ass.net>
References: <1472762024-88771-1-git-send-email-srinivas.pandruvada@linux.intel.com>
 <1472762024-88771-3-git-send-email-srinivas.pandruvada@linux.intel.com>
 <20160908080111.GT10153@twins.programming.kicks-ass.net>
 <20160908180325.GA23509@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160908180325.GA23509@linux.intel.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 08, 2016 at 11:03:26AM -0700, Tim Chen wrote:
> On Thu, Sep 08, 2016 at 10:01:11AM +0200, Peter Zijlstra wrote:
> > On Thu, Sep 01, 2016 at 01:33:38PM -0700, Srinivas Pandruvada wrote:
> > > +++ b/kernel/sched/sched.h
> > > @@ -532,6 +532,17 @@ struct dl_rq {
> > >  
> > >  #ifdef CONFIG_SMP
> > >  
> > > +static inline bool sched_asym_prefer(int a, int b)
> > > +{
> > > +	return arch_asym_cpu_priority(a) > arch_asym_cpu_priority(b);
> > > +}
> > > +
> > > +/*
> > > + * Return lowest numbered cpu in the group as the most preferred cpu
> > > + * for ASYM_PACKING for default case.
> > > + */
> > > +#define group_priority_cpu(group) group->asym_prefer_cpu
> > > +
> > 
> > Both these are no longer used outside of sched/fair.c, and should
> > probably be moved there. Also the later has no reason for being a macro.
> 
> Peter,
> 
> The sched_asym_prefer is used in sched/core.c to set asym_prefer_cpu
> in a group. So we will still need the definition in sched.h.  I've removed
> the group_priority_cpu macro.

Ah indeed. Thanks!