From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941145AbcIHWFT (ORCPT ); Thu, 8 Sep 2016 18:05:19 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:52681 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932233AbcIHWFO (ORCPT ); Thu, 8 Sep 2016 18:05:14 -0400 Date: Thu, 8 Sep 2016 15:04:12 -0700 From: Shaohua Li To: Fenghua Yu CC: Thomas Gleixner , "H. Peter Anvin" , Ingo Molnar , Tony Luck , Peter Zijlstra , Tejun Heo , Borislav Petkov , Stephane Eranian , Marcelo Tosatti , "David Carrillo-Cisneros" , Ravi V Shankar , Vikas Shivappa , Sai Prakhya , linux-kernel , x86 Subject: Re: [PATCH v2 27/33] x86/intel_rdt_rdtgroup.c: Implement resctrl file system commands Message-ID: <20160908220412.GB64153@shli-mbp.local> References: <1473328647-33116-1-git-send-email-fenghua.yu@intel.com> <1473328647-33116-28-git-send-email-fenghua.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1473328647-33116-28-git-send-email-fenghua.yu@intel.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [2620:10d:c090:200::e:4cd0] X-ClientProxiedBy: BN6PR04CA0002.namprd04.prod.outlook.com (10.172.194.12) To SN2PR15MB0944.namprd15.prod.outlook.com (10.169.191.146) X-MS-Office365-Filtering-Correlation-Id: 25519375-4af3-413c-32dc-08d3d834196d X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB0944;2:fCZwNCGAWuA6+MMYYPwBWgxF1VShF5iLC7MGWAY5QsBHxTNeEeWFaxlqAic24Z4PrCcdrr54jwKLSlM503u0tGPW5ZHr6kCcQjbpurUWE6/jdSPIDGfAhsXKg8E6D8pEdkPHOO+7W1sox1Dzabajku/sgQWXWCNoFATdISKKRJv2NZq0ngcY2hT7FuGWLZZP;3:XGkWws6+0yP235gQLCl29rCikTJs+Gd9SzSkvHsPO88BTnIFAAa/5/SC336zZaOw0tvMM6n3YnjOHDybMAU2BZUUq6nPlq9N5NGqcgFNpuPv1gL2PoYqSWS57T64hDWn;25:Kr3Oo+RQSikWBOfGy6/S9vwt8nLdRxv/AfLcXPrO+Zgn2lX95UwKJo6FhET/hL0mXVEL+IxWMZR7gH0qa8/RUgQFiZhwdPdPFv4rK0PtZtiXKMAr1302jl+JYovnnmkJAg06PH3o/61Ji0Wl1bL1xQeuChwos82QAobZlH3QQY1gu1Zn4pklBEff/xhPOUvaiTDyHo7sS08M+lTdyYhv3dwsGyYRYQoPqrQAvQoRg6ivIOj3rt/7yy6/OTIkMN4zbpJWffXi6rxDvNPAVu7L0pbrcsZ49Vg8+y7+7D4pGHUDaeHidv1Mxe2RPIuxbStI0hBL0J+DhGlAuYTPmWD0aHe6P9jDOV0LtDYvmg/ty8JrO7Vdugc3YkKH+KMl0TXpR+xEVp/qhKBxzrY2SyE9TTx9I+JlIYQ3EJsKefA0Ia4= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN2PR15MB0944; X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB0944;31:F6nZUW6rb9oYYewDqaymKHWFynnEm15DFEygqquQj1t9s2hznI+LXjpPfaath2hQiVcXxt1N4p6FkH+Xo1k+az5rLFqgh0vW0LnfyCKphu2aRihlyUDYnuzffBXWIM3rSyIuuNHk0xokzKKiOi8C0ye1tsLMBjuni3/4VOnT14gyubT2YWpRW4Vag27A7TMH0mKxqWeHS2OO0pV4eCC1twNFF6wMqgxgfXWq6fdZ4H8=;20:PrZhMBgkjDLViLXqYbmq2vTVt7W4yK/ZT6ZNLQStHtk+IusmoTRqfBlp6f0yrnoIht8F+K2OdJxtFAqJ0MdizMij6R1B/RpEJECgXQI6viknIYt3FLmmrmy7rOCA5aaS6C/N+8hJELEC4OJBQJeOUB45esfB1kXhD3Y6OBxw1Qc=;4:N3+JU/uaMkpnPrQVqU2mjBlLCVfFI2LCgxVBOl2oZJttSSTpyNLlSt3TpaSvlF3gFao/dVSHUOHkZeMZ/bRDAMQ1b1HHVaMKLhVkrwcOji9Cvdn4MU9Ex37vHM1CDZ1oOmgGvSc3NCR+r1MQfpIOWD92T/Fvt5LsqyfK7OWvzRigM5z5DQ8+P1jyqeVWouKXeeYL48ZRaXd/j4PhENzVVM1Ofmw7HCvqUf2wUK5vc7/rpXqjxgW395IcaiuVO3v8CMbrL6FqgTuYTcu9KeB5WYdjqhjKrO27MYjB1jN3+Rl6UcMcIr18AjjHc/uF/CyPD4MlOZzAL8blA4/5kGuAJwy3TQM/ELxoXlS4WD3Jk6Zvpqm+KMkPnmtqr+lCo+7q X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:SN2PR15MB0944;BCL:0;PCL:0;RULEID:;SRVR:SN2PR15MB0944; X-Forefront-PRVS: 00594E8DBA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(189002)(199003)(24454002)(2906002)(81166006)(97756001)(9686002)(81156014)(97736004)(105586002)(8676002)(2950100001)(7736002)(7416002)(4326007)(106356001)(68736007)(92566002)(47776003)(33656002)(305945005)(7846002)(98436002)(46406003)(50986999)(189998001)(4001350100001)(50466002)(76176999)(6116002)(101416001)(54356999)(86362001)(83506001)(110136002)(586003)(42186005)(1076002)(5660300001)(23726003)(77096005)(18370500001)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:SN2PR15MB0944;H:shli-mbp.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR15MB0944;23:hYBFionLU5fEMGzxd+MIccWUTPj6PT1B3SdiEdSgU?= =?us-ascii?Q?o7N9cvIx/YBxBBnRJHsPAMs/jPBcr+6zfbW3+bqvEaxxybakp2hPcQWvO86U?= =?us-ascii?Q?2PAmPJr6opatuA2Sss2+zr4QhpioiGY/dk54KeSb/Q33bpo2otkWl4jcSTZV?= =?us-ascii?Q?9o382cRu0fAFoQ9bE0mQBb0KiewURPSGqykF9w+H6eesR5v/FdBoCUj/7tde?= =?us-ascii?Q?nAfQuXVy2Ana7UwyKbtgdl2GvMTGW/u1Vixvf7Kur6YM6XGP6O6UO1zqmFPp?= =?us-ascii?Q?38aYUoFddUoWlq42YNrNcghVy4tqV86VCYUxxGPUPdGIZpRbVN9ktrf6KsXy?= =?us-ascii?Q?D4y2a5VQNyON7+Q6yScjhM+0RvB/tskRfEhI9yuv6WcthCxr7vGEaeyr6QFW?= =?us-ascii?Q?UaKLT87jD6LwdP+yIowdkD1F9UNEnCx/+PdDRk1yn8ZTHTsibNLgUtDXHXsy?= =?us-ascii?Q?M+A6hVTD4fdvzKX5WVIdurVU+WSQtP5QnpKkTUCoOuj6n78g8XgQAQbbnhPB?= =?us-ascii?Q?5xtLeDu1rjAKDUBufmKfIvFt9TRRxnIi77D8/aligmBiVs4ltRZlGZJVTd60?= =?us-ascii?Q?9cjvbWf4tCmJxFMDUwIBWga4PQ/XJ/YE8d+kRzvjeOYG/GhuG5siwelFDenZ?= =?us-ascii?Q?6XAdTU8IwyhAcMV10E557WCNflya1HYSAsqGI+yiyZwZfbu+xSvPDsTbIvn0?= =?us-ascii?Q?G62kP5LekVKreW2K02WIj7yxr1cRs9DviBpLRK7JV4iKRBrmP0OJuUjNa6Du?= =?us-ascii?Q?lo6pItVwT++5TZU7GwQ6MTAuanhzayT7E7Tdgq2iQo6Rzg+9jKDszkt5T/MA?= =?us-ascii?Q?5RjIh3U7sI7syfpai9nG+OAAsP1gzucpLlNLvTLgUs4fWXq6GyBeQEchUoOa?= =?us-ascii?Q?MyXn23fJzyRT42WzBFYU6LSqnmyrsjokojC7QDBSvZLXYAqlCjKnXNgAkZYE?= =?us-ascii?Q?66F7UoB71Ni1oqhdswSw+snahUcto+xRd9drNEsjljJvqdKqlFHyCmRmI17O?= =?us-ascii?Q?QfavIU9BjkqJaD1NvzHFc8qU7oSzeTAekNrSKryH5HhWwFTRGjwc71dvnztD?= =?us-ascii?Q?B3z+RoDST8eMy0ZK0qqxq1Loy1oeEnuQjvenFKui2MaC5I4FQCeWYMF4TmUC?= =?us-ascii?Q?5BY9afhqTEJREe+EcBA9pddIX8eqwr+?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB0944;6:v3wmSQKNjLUZkseuUZ1lchaAwxv1sePufRyJhEdm0TAv81FBxEaCriVVM1MNSvmjGtb3zLWunUzwHaOkV1wqSz6HVx3Q3omJxIQLBhHAwLVgtoW2AOIwNU7+szeCdmeM6npUj5k6NakM4Te8zglrVjZDQJOA5czLC7IInBFGtIvHy1Z0J9kkh1/m758Tl80bxFjngcXPY8niYOLsQcmW3Lb2NppqS/CN7VpQaF8gMqmJDF8DEFyF6gLXWBAihzfSdrEP1EUzC8yzpBXpfwPU1VsTNWHbIVdk2TWAJOmDmDk=;5:UFawzIHZ28L3F6c8dUXzU/2xTN0+TfCgg9v1RDEnhB69cs8o853TYz6hPelPxoLf1T3vPjrcQLDBJUIH37KGy4Poau+bsiCeBDdi96qsdMgqdE1l4MkJcG03Ve0vaEwiKPqM6INSESTxTJPB9eQa6g==;24:9Xbc6fpZm9ArEfuiVRJod5HCms0L+vgxJfYlD84vO6Ca7soFg65v4zNd60RMrzQOvWc9rskWPExQNkqL+2wJXLeRFkqVs+8lMGhVngMy6QA=;7:7obN3gMXXI2x6j6uG8uWbLIOqGR+VUkrStk9zTDQCfQaKER7Lt0hAC7raHWRTfhxuWyXPNrzIq9XqChElCuEzahzd4ysacg+QjR93fYKJsF6/FqJpE+XHWt8BCk7emXQ1OaWIz1ElXrjtv3KTcSbI/pIi+DGgAYSwaE8WIrnoYwAXl7pqHEg0Kg49/yB8troHjfLGeuKQrWEZ8GFZwyuQ5k9RmBMCJ9mshxiBqjBpQ0sjv37pVBMDE0YZUU2O96M SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB0944;20:3ua4ywYk9XVfkPO3deFt2S1PKO/GctCQHmcAlRre/JL97v8INqS7/1mbECgt3FzJVQF8Pkadljxp+WQ+e3U7phSh9N9vreAvMxLO29kwqfmJqO6xM6fUvEqqz8oUC2v2Lg7i/bI8/R3DyVLL8mcdkuJDT6I2j4nTWPN5KXKY30o= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2016 22:04:24.2138 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR15MB0944 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-08_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 08, 2016 at 02:57:21AM -0700, Fenghua Yu wrote: > /* > * kernfs_root - find out the kernfs_root a kernfs_node belongs to > @@ -730,6 +749,110 @@ static void rdtgroup_destroy_locked(struct rdtgroup *rdtgrp) > kernfs_remove(rdtgrp->kn); > } > > +static int rdtgroup_mkdir(struct kernfs_node *parent_kn, const char *name, > + umode_t mode) > +{ > + struct rdtgroup *parent, *rdtgrp; > + struct rdtgroup_root *root; > + struct kernfs_node *kn; > + int ret; > + > + if (parent_kn != root_rdtgrp->kn) > + return -EPERM; > + So we can't create nested groups. Is this limitation temporary? I don't see this is mentioned in the interface document. Thanks, Shaohua