From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754876AbcIIMuf (ORCPT ); Fri, 9 Sep 2016 08:50:35 -0400 Received: from mail.skyhub.de ([78.46.96.112]:46751 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754685AbcIIMue (ORCPT ); Fri, 9 Sep 2016 08:50:34 -0400 Date: Fri, 9 Sep 2016 14:50:24 +0200 From: Borislav Petkov To: Colin King , Tony Luck Cc: Mauro Carvalho Chehab , Doug Thompson , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] EDAC: sb_edac: remove null pointer check on array pci_tad Message-ID: <20160909125024.5ozjo2swdddd63ra@pd.tnic> References: <20160908083801.14766-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160908083801.14766-1-colin.king@canonical.com> User-Agent: NeoMutt/ (1.7.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + Tony. On Thu, Sep 08, 2016 at 09:38:01AM +0100, Colin King wrote: > From: Colin Ian King > > pvt->pci_tad is a NUM_CHANNELS array of struct pci_dev pointers and > hence cannot be null, so the pull pointer check on pci_tad is > redundant. Remove it. > > Signed-off-by: Colin Ian King > --- > drivers/edac/sb_edac.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c > index ce0067b..5477522 100644 > --- a/drivers/edac/sb_edac.c > +++ b/drivers/edac/sb_edac.c > @@ -2474,7 +2474,7 @@ static int sbridge_mci_bind_devs(struct mem_ctl_info *mci, > > /* Check if everything were registered */ > if (!pvt->pci_sad0 || !pvt->pci_sad1 || !pvt->pci_ha0 || > - !pvt-> pci_tad || !pvt->pci_ras || !pvt->pci_ta) > + !pvt->pci_ras || !pvt->pci_ta) > goto enodev; > > if (saw_chan_mask != 0x0f) > @@ -2563,8 +2563,7 @@ static int ibridge_mci_bind_devs(struct mem_ctl_info *mci, > > /* Check if everything were registered */ > if (!pvt->pci_sad0 || !pvt->pci_ha0 || !pvt->pci_br0 || > - !pvt->pci_br1 || !pvt->pci_tad || !pvt->pci_ras || > - !pvt->pci_ta) > + !pvt->pci_br1 || !pvt->pci_ras || !pvt->pci_ta) > goto enodev; > > if (saw_chan_mask != 0x0f && /* -EN */ > -- > 2.9.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-edac" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.