From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752422AbcIIPaI (ORCPT ); Fri, 9 Sep 2016 11:30:08 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:57960 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbcIIPaG (ORCPT ); Fri, 9 Sep 2016 11:30:06 -0400 Date: Fri, 9 Sep 2016 16:29:52 +0100 From: Mark Brown To: Andy Shevchenko Cc: "linux-kernel@vger.kernel.org" , "Hunter, Adrian" Message-ID: <20160909152952.GS27946@sirena.org.uk> References: <1472741623.4887.482.camel@linux.intel.com> <20160901153836.GI5967@sirena.org.uk> <1472746516.4887.489.camel@linux.intel.com> <20160901170215.GJ5967@sirena.org.uk> <1473091312.11323.20.camel@linux.intel.com> <20160906102407.GF3950@sirena.org.uk> <1473258241.11323.83.camel@linux.intel.com> <20160909121749.GR27946@sirena.org.uk> <1473425727.11323.144.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="b2ktwntdbf0dPnbx" Content-Disposition: inline In-Reply-To: <1473425727.11323.144.camel@linux.intel.com> X-Cookie: Question authority. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: Regulator probe X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --b2ktwntdbf0dPnbx Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 09, 2016 at 03:55:27PM +0300, Andy Shevchenko wrote: > On Fri, 2016-09-09 at 13:17 +0100, Mark Brown wrote: > > What do you mean?=A0=A0Of course we should handle probe deferral if we > > fail to get a resource like a GPIO.=A0=A0Are you trying to say that this > > doesn't work for you? > No, it doesn't. > Fixed regulator probe is deferred: > reg-fixed-voltage reg-fixed-voltage.0.auto: Failed to register > regulator: -517 So the regulator probe *does* get deferred as expected... > But: > sdhci-pci 0000:00:01.3: No vmmc regulator found > Code in sdhci driver is: > =A0 =A0 =A0 =A0 ret =3D mmc_regulator_get_supply(mmc); > =A0=A0=A0=A0=A0=A0=A0=A0if (ret =3D=3D -EPROBE_DEFER) > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0return ret; > > mmc_regulator_get_supply(): > ... > =A0 =A0 =A0 =A0 mmc->supply.vmmc =3D devm_regulator_get_optional(dev, "vm= mc"); > =A0=A0=A0=A0=A0=A0=A0=A0mmc->supply.vqmmc =3D devm_regulator_get_optional= (dev, "vqmmc"); =2E..and then we correctly report that the optional supply that isn't mapped (as far as I remember) isn't there. --b2ktwntdbf0dPnbx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJX0tVvAAoJECTWi3JdVIfQJKcH/Av5Q2BeArznWwH6Peb4xcbM 5pD8TfIwg3EsCmFBuXBWptFQ+gMNBO8QdWiezbiffNrjkGiT8cAAJh2Cdhl3dfby BF70x/Ci9De03PvlVkog2nLMLl6WawrCBLxjh2+jd1e8ME7EpQuWA9lnf7m96Aiq R4TBPDLSzTi4gKczlDfTcJ+GEt9YAYTKqZhmUGWpYcqt8OKdc9FSPS4s/r/roS3l dFwKXt4KpU17K26Gusxp44KXulqAyH307vCeTrGU7SqkNNMfJMSI6mpuq5L8MAkY oSCQ5BwEqFfJlWIXteqCvRz9X3ZpfAUCO12lufgw389pRHJoaazcpUNL+ls8L0s= =PuSB -----END PGP SIGNATURE----- --b2ktwntdbf0dPnbx--