From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753907AbcIJT6r (ORCPT ); Sat, 10 Sep 2016 15:58:47 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:57573 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751696AbcIJT6q (ORCPT ); Sat, 10 Sep 2016 15:58:46 -0400 From: Arnd Bergmann To: Brian Norris Cc: kernel-build-reports@lists.linaro.org, Arnd Bergmann , David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] mtd: pmcmsp: use kstrndup instead of kmalloc+strncpy Date: Sat, 10 Sep 2016 21:57:35 +0200 Message-Id: <20160910195748.1360407-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:PXGiYS5Sg3kGe3cqsoHVDHyptsNYZJ9C871PcQuupr1eSNvIly/ unbEbqrbchhh9MecjK9KPJWK5CYc9Jrjbzv3fpLD4bKl/bJoOuC09VTTIEpWpnN99SzZISW qmKcShgplcfspMM+BhzTq0L+ct3PX4XR4RxZeqvzEL7ay2qqYcitlkTJFJwBj8ory7RBvhk DF7rCtHEnOAO+8neIB/YQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:WVJ8RJmLVpU=:xTT7iVABXd6kEAzNPSpplR h6MfVbacKIltY55RUZ3lMXSuEeiwzfX/tg40fP5IKgQ/DzfL69qjjn28HoCJNtbs0dbJLAQCP Ud2Mm8t3d78bLgluTUu9U2uP7n+Eo5T24mO8Oo1TSiIJp81YtwY/boctXv+7UmZ/F7Oj8bHoB BkEyQ4bc8wc2Ujqmzu1sn1NR4M55V4KHk5WNz9UnlhMiTOf480/F8ujKKAwASWHMKQF8KQpAn 3Rpe/lzQRpipLJFwwiH1KEwXfEaSZpFnbABpsR/pfySzaHHjS2XlXvcEM3mxPIYIRj9CGsJ5y gXYMSbz/+/tjtLvUI7iht71rPv5l2JmbUdD40ssgMUkStEPrVYrJRukaVuwO7qdiSey+EoJC0 5KrV6bQx1Z8S5+Ah5wP4EDeMmWJSa3lKkKfo8vmof5cm+bUGX2HiyTnggdR7pOrCDuoT9044a 3z5G0pZo2B7JyhKDksUPlNNiqbgY83kRXl7mwhM3CAgL9NeJj9nwidbP/O1ZT4Zwvrl6xuoy5 f8VZKWe8C30dlhi2vjPweZNcF8mQCL945YjvVf0LKyT5Ajg9NYA9MRT1ikpnIHGSlJUQPp/Kn LZXVp0deSzkyAkuOVjpwqcb182lR+Mpk2PCvlo7It6zS4fkBf+yp+u3inpdyHq7XyG9qkIRFT lMGpu1A8r7DbhWL4sw1mhyrQwS+v5Jh+XMuvqrXArjIwolGJaWCOpYBd+mWXicQh/jc0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kernelci.org reports a warning for this driver, as it copies a local variable into a 'const char *' string: drivers/mtd/maps/pmcmsp-flash.c:149:30: warning: passing argument 1 of 'strncpy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] Using kstrndup() simplifies the code and avoids the warning. Signed-off-by: Arnd Bergmann --- drivers/mtd/maps/pmcmsp-flash.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mtd/maps/pmcmsp-flash.c b/drivers/mtd/maps/pmcmsp-flash.c index 744ca5cacc9b..cf54420f943d 100644 --- a/drivers/mtd/maps/pmcmsp-flash.c +++ b/drivers/mtd/maps/pmcmsp-flash.c @@ -139,15 +139,13 @@ static int __init init_msp_flash(void) } msp_maps[i].bankwidth = 1; - msp_maps[i].name = kmalloc(7, GFP_KERNEL); + msp_maps[i].name = kstrndup(flash_name, 7, GFP_KERNEL); if (!msp_maps[i].name) { iounmap(msp_maps[i].virt); kfree(msp_parts[i]); goto cleanup_loop; } - msp_maps[i].name = strncpy(msp_maps[i].name, flash_name, 7); - for (j = 0; j < pcnt; j++) { part_name[5] = '0' + i; part_name[7] = '0' + j; -- 2.9.0