From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756555AbcILCsY (ORCPT ); Sun, 11 Sep 2016 22:48:24 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:37040 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755550AbcILCsX (ORCPT ); Sun, 11 Sep 2016 22:48:23 -0400 Date: Sun, 11 Sep 2016 19:48:19 -0700 (PDT) Message-Id: <20160911.194819.1394072668837372328.davem@davemloft.net> To: Julia.Lawall@lip6.fr Cc: netdev@vger.kernel.org, joe@perches.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 25/26] pch_gbe: constify local structures From: David Miller In-Reply-To: <1473599168-30561-26-git-send-email-Julia.Lawall@lip6.fr> References: <1473599168-30561-1-git-send-email-Julia.Lawall@lip6.fr> <1473599168-30561-26-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 11 Sep 2016 19:48:19 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Julia, I went over the networking driver patches in this series and I have to say that I'd rather see these changes be more durable and self-checking. By this I mean that I want you to also make the driver private pointer that holds these structures be const too. Then if there are really any assignments to the objects being marked const, it will show immediately. Thank you.