From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757833AbcILLTa (ORCPT ); Mon, 12 Sep 2016 07:19:30 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34575 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751955AbcILLT2 (ORCPT ); Mon, 12 Sep 2016 07:19:28 -0400 Date: Mon, 12 Sep 2016 13:19:32 +0200 From: Greg KH To: Claudiu Beznea Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: wlan-ng: improve code aspect in p80211req_mibset_mibget() Message-ID: <20160912111932.GA18305@kroah.com> References: <1473179450-7643-1-git-send-email-claudiu.beznea@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473179450-7643-1-git-send-email-claudiu.beznea@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 06, 2016 at 07:30:50PM +0300, Claudiu Beznea wrote: > This patch improves code aspect in p80211req_mibset_mibget() function > by removing accolades which followed case statements. To do so, > some data variable ware declared at the beginning of the > function and also pstr and key variables were initialized > only in the code which uses them. > > Signed-off-by: Claudiu Beznea > --- > drivers/staging/wlan-ng/p80211req.c | 33 ++++++++++++++++++--------------- > 1 file changed, 18 insertions(+), 15 deletions(-) Didn't apply to my tree for some reason, can you refresh and resend? thanks, greg k-h