From: Mark Brown <broonie@kernel.org>
To: NeilBrown <neilb@suse.com>
Cc: Baolin Wang <baolin.wang@linaro.org>,
NeilBrown <nfbrown@novell.com>, Felipe Balbi <balbi@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
robh@kernel.org, Jun Li <jun.li@nxp.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Ruslan Bilovol <ruslan.bilovol@gmail.com>,
Peter Chen <peter.chen@freescale.com>,
Alan Stern <stern@rowland.harvard.edu>,
r.baldyga@samsung.com, grygorii.strashko@ti.com,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Lee Jones <lee.jones@linaro.org>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
patches@opensource.wolfsonmicro.com,
Linux PM list <linux-pm@vger.kernel.org>,
USB <linux-usb@vger.kernel.org>,
device-mainlining@lists.linuxfoundation.org,
LKML <linux-kernel@vger.kernel.org>,
"Bird, Timothy" <Tim.Bird@am.sony.com>
Subject: Re: [PATCH v16 0/4] Introduce usb charger framework to deal with the usb gadget power negotation
Date: Mon, 12 Sep 2016 13:25:49 +0100 [thread overview]
Message-ID: <20160912122549.GZ27946@sirena.org.uk> (raw)
In-Reply-To: <87pooc7n3t.fsf@notabene.neil.brown.name>
[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]
On Sat, Sep 10, 2016 at 07:57:26AM +1000, NeilBrown wrote:
> On Fri, Sep 09 2016, Mark Brown wrote:
> > The wm831x driver in the patch series is an example of such hardware -
> > it is purely a power manager, it has no USB PHY hardware at all. It's a
> The "probe" routine calls
> + usb_charger_find_by_name(wm831x_pdata->usb_gadget);
> Presumably wm831x_pdata is initialised by a board file?
Yes.
> I strongly suspect it is initialized to "usb-charger.0" because the
> names given to usb chargers are "usb-charger.%d" in discovery order.
> I don't see this being at all useful if there is ever more than one
> usb-charger.
> Do you?
It's no worse than any other board file situation - if someone has that
problem they get to fix it.
> So how can this wm831x driver actually find out what sort of charger is
> connected and so set the power limit? I just don't see this working *at*
> *all*.
The whole point from the point of view of the wm831x driver is that it
just wants something to tell it how much current it's allowed to draw, I
appreciate that doesn't change your analysis of the bit in the middle
but the consumer driver bit seems fine here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-09-12 12:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 7:09 Baolin Wang
2016-08-01 7:09 ` [PATCH v16 1/4] usb: gadget: Introduce the usb charger framework Baolin Wang
2016-08-01 7:09 ` [PATCH v16 2/4] usb: gadget: Support for " Baolin Wang
2016-08-01 7:09 ` [PATCH v16 3/4] usb: gadget: Integrate with the usb gadget supporting for usb charger Baolin Wang
2016-08-01 7:09 ` [PATCH v16 4/4] power: wm831x_power: Support USB charger current limit management Baolin Wang
2016-08-11 3:14 ` [PATCH v16 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Baolin Wang
2016-08-29 9:02 ` Baolin Wang
2016-09-06 5:40 ` NeilBrown
2016-09-06 7:40 ` Felipe Balbi
2016-09-08 6:55 ` Baolin Wang
2016-09-08 7:31 ` NeilBrown
2016-09-08 8:12 ` Baolin Wang
2016-09-08 23:13 ` NeilBrown
2016-09-09 6:46 ` Baolin Wang
2016-09-09 21:19 ` NeilBrown
2016-09-18 9:39 ` Baolin Wang
2016-10-05 7:26 ` Baolin Wang
2016-10-05 7:47 ` Felipe Balbi
2016-10-05 7:57 ` Baolin Wang
2016-10-05 10:44 ` NeilBrown
2016-10-08 3:18 ` Baolin Wang
2016-09-09 11:07 ` Mark Brown
2016-09-09 21:57 ` NeilBrown
2016-09-12 12:25 ` Mark Brown [this message]
2016-09-12 13:27 ` NeilBrown
2016-09-12 15:26 ` Mark Brown
2016-09-13 8:00 ` NeilBrown
2016-09-14 11:16 ` Mark Brown
2016-09-14 14:11 ` NeilBrown
2016-09-14 14:57 ` Mark Brown
2016-09-14 17:50 ` NeilBrown
2016-09-14 18:02 ` Mark Brown
2016-09-15 10:33 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912122549.GZ27946@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Tim.Bird@am.sony.com \
--cc=balbi@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=dbaryshkov@gmail.com \
--cc=device-mainlining@lists.linuxfoundation.org \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=jun.li@nxp.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=neilb@suse.com \
--cc=nfbrown@novell.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=peter.chen@freescale.com \
--cc=r.baldyga@samsung.com \
--cc=robh@kernel.org \
--cc=ruslan.bilovol@gmail.com \
--cc=sre@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®