From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758864AbcILN1G (ORCPT ); Mon, 12 Sep 2016 09:27:06 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:34016 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758675AbcILN1E (ORCPT ); Mon, 12 Sep 2016 09:27:04 -0400 Date: Mon, 12 Sep 2016 08:27:02 -0500 From: Rob Herring To: Andi Shyti Cc: Mauro Carvalho Chehab , Sean Young , Mark Rutland , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Andi Shyti Subject: Re: [PATCH v2 6/7] Documentation: bindings: add documentation for ir-spi device driver Message-ID: <20160912132702.GA20044@rob-hp-laptop> References: <20160901171629.15422-1-andi.shyti@samsung.com> <20160901171629.15422-7-andi.shyti@samsung.com> <20160902053320.wqe5hklklnyvcc5m@samsunx.samsung> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160902053320.wqe5hklklnyvcc5m@samsunx.samsung> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 02, 2016 at 02:33:20PM +0900, Andi Shyti wrote: > Hi Rob, > > > > Document the ir-spi driver's binding which is a IR led driven > > > through the SPI line. > > > > > > Signed-off-by: Andi Shyti > > > --- > > > Documentation/devicetree/bindings/media/spi-ir.txt | 26 ++++++++++++++++++++++ > > > 1 file changed, 26 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/spi-ir.txt > > > > > > diff --git a/Documentation/devicetree/bindings/media/spi-ir.txt b/Documentation/devicetree/bindings/media/spi-ir.txt > > > new file mode 100644 > > > index 0000000..85cb21b > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/spi-ir.txt > > > > Move this to bindings/leds, and CC the leds maintainers. > > More than an LED this is the driver of a remote controller, the > driver itself is under drivers/media/rc/. The hardware is just an LED though and bindings describe h/w. What you are using it for doesn't really matter. You only need to know it's an IR led. > Besides all the transmitters have an LED but still they are media > devices. This is a bit special because it's so simple that the > only hardware left is the LED itself, but still it's a media remote > controller. > > > > @@ -0,0 +1,26 @@ > > > +Device tree bindings for IR LED connected through SPI bus which is used as > > > +remote controller. > > > + > > > +The IR LED switch is connected to the MOSI line of the SPI device and the data > > > +are delivered thourgh that. > > > + > > > +Required properties: > > > + - compatible: should be "ir-spi". > > > > Really this is just an LED connected to a SPI, so maybe this should > > just be "spi-led". If being more specific is helpful, then I'm all for > > that, but perhaps spi-ir-led. (Trying to be consistent in naming with > > gpio-leds). > > As I mentioned above, all transmitters have an LED, but they do > not have the 'led' name. "ir-spi" is coherent with the device > driver name and the driver name is coherent with the media/rc > driver's naming. The driver name is irrelevant to the binding. [...] > If it's OK for you, I would keep the name and documentation path > and fix the rest. Please let me know if I'm missing something :) It's not OK for me. Rob