From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Paul Liu <paul.liu@canonical.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] mfd: intel-lpss: Add default I2C device properties for Apollo Lake
Date: Mon, 12 Sep 2016 16:43:53 +0300 [thread overview]
Message-ID: <20160912134353.GH1811@lahna.fi.intel.com> (raw)
In-Reply-To: <20160912114133.7038-1-jarkko.nikula@linux.intel.com>
On Mon, Sep 12, 2016 at 02:41:33PM +0300, Jarkko Nikula wrote:
> Default I2C device properties for Intel Broxton, especially SDA hold time
> may not be enough on Intel Apollo Lake. These properties are used in case
> we don't get timing parameters from ACPI.
>
> The default SDA hold time for Broxton may fail with arbitration lost errors
> on Apollo Lake:
>
> i2c_designware i2c_designware.1: i2c_dw_handle_tx_abort: lost arbitration
>
> Fix this by using different default device properties on Apollo Lake than
> Broxton.
>
> Reported-by: Paul Liu <paul.liu@canonical.com>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=156181
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2016-09-12 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 11:41 Jarkko Nikula
2016-09-12 13:43 ` Mika Westerberg [this message]
2016-09-12 13:56 ` Lee Jones
2016-09-13 8:59 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912134353.GH1811@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.liu@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome