From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933181AbcILO3R (ORCPT ); Mon, 12 Sep 2016 10:29:17 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:37363 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933178AbcILO3O (ORCPT ); Mon, 12 Sep 2016 10:29:14 -0400 Date: Mon, 12 Sep 2016 15:28:50 +0100 From: Russell King - ARM Linux To: Colin King Cc: Vineet Gupta , Hans-Christian Noren Egtvedt , Joerg Roedel , Robin Murphy , Jesper Nilsson , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] dma-mapping: add in missing white space in error message text Message-ID: <20160912142849.GV1041@n2100.armlinux.org.uk> References: <20160912130952.2778-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160912130952.2778-1-colin.king@canonical.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2016 at 02:09:52PM +0100, Colin King wrote: > From: Colin Ian King > > A dev_warn message spans two lines and the literal string is missing > a white space between words. Add the white space and reformat the > message to not span multiple lines. > > Signed-off-by: Colin Ian King > --- > arch/arm/common/dmabounce.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c > index 3012816..afeb5e3 100644 > --- a/arch/arm/common/dmabounce.c > +++ b/arch/arm/common/dmabounce.c > @@ -546,9 +546,7 @@ void dmabounce_unregister_dev(struct device *dev) > set_dma_ops(dev, NULL); > > if (!device_info) { > - dev_warn(dev, > - "Never registered with dmabounce but attempting" > - "to unregister!\n"); > + dev_warn(dev, "Never registered with dmabounce but attempting to unregister!\n"); Almost! dev_warn(dev, "Never registered with dmabounce but attempting to unregister!\n"); The point is that the string is as greppable as possible, while trying to keep to the rest of the style. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.