From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758958AbcILOdm (ORCPT ); Mon, 12 Sep 2016 10:33:42 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:37397 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758114AbcILOdl (ORCPT ); Mon, 12 Sep 2016 10:33:41 -0400 Date: Mon, 12 Sep 2016 15:33:22 +0100 From: Russell King - ARM Linux To: Robin Murphy Cc: Colin King , Vineet Gupta , Hans-Christian Noren Egtvedt , Joerg Roedel , Jesper Nilsson , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text Message-ID: <20160912143322.GW1041@n2100.armlinux.org.uk> References: <20160912125212.32739-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2016 at 02:06:09PM +0100, Robin Murphy wrote: > On 12/09/16 13:52, Colin King wrote: > > From: Colin Ian King > > > > A dev_warn message spans two lines and the literal string is missing > > a white space between words. Add the white space. > > > > Signed-off-by: Colin Ian King > > --- > > arch/arm/common/dmabounce.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c > > index 3012816..f47767b 100644 > > --- a/arch/arm/common/dmabounce.c > > +++ b/arch/arm/common/dmabounce.c > > @@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev) > > > > if (!device_info) { > > dev_warn(dev, > > - "Never registered with dmabounce but attempting" > > + "Never registered with dmabounce but attempting " > > "to unregister!\n"); > > Per Documentation/CodingStyle, better to put the whole thing onto one > line so that, say, "git grep 'attempting to unregister'" doesn't leave > one scratching ones head in confusion. > > Of course, even better would be to get rid of the whole thing and > convert ARM to use SWIOTLB, but hey, one thing at a time ;) I doubt that can happen - dmabounce does a little more than swiotlb because it copes with DMA masks that are _not_ a number of zeros followed by one bits. It was written to support things like SA1111 DMA, where the device has a bug in that it can't drive certain SDRAM address bits correctly. It also gets used for ITE8512 PCI controllers and IXP4xx platforms, although these should probably be converted to SWIOTLB. However, without having test systems, I'd recommend leaving them as-is. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.